Merge pull request #342 from shyim/patch-1

fix: php 8.4 deprecation about implicit null arguments
cocur · Aug 27, 2024 · f48ab34 · f48ab34
2 parents 98d5b56 + 38e4d18
commit f48ab34
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 54 deletions.
diff --git a/.github/workflows/unit.yml b/.github/workflows/unit.yml
@@ -27,6 +27,9 @@ jobs:
           - php: "8.3"
             mode: experimental
             os: ubuntu-20.04
+          - php: "8.4"
+            mode: experimental
+            os: ubuntu-20.04
       fail-fast: false
 
     runs-on: "${{ matrix.os }}"

diff --git a/.travis.yml b/.travis.yml
diff --git a/composer.json b/composer.json
@@ -19,7 +19,7 @@
         }
     ],
     "require": {
-        "php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0",
+        "php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
         "ext-mbstring": "*"
     },
     "conflict": {

diff --git a/src/Slugify.php b/src/Slugify.php
@@ -80,7 +80,7 @@ class Slugify implements SlugifyInterface
      * @param array                 $options
      * @param RuleProviderInterface $provider
      */
-    public function __construct(array $options = [], RuleProviderInterface $provider = null)
+    public function __construct(array $options = [], ?RuleProviderInterface $provider = null)
     {
         $this->options  = array_merge($this->options, $options);
         $this->provider = $provider ? $provider : new DefaultRuleProvider();