Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GitHub Actions to supported languages #1963

Merged
merged 6 commits into from
Dec 11, 2023

Conversation

nicklem
Copy link
Contributor

@nicklem nicklem commented Nov 28, 2023

Adds GitHub actions to the Supported languages and tools and Security monitor pages. See thread for context.

👀 Live preview

Copy link
Contributor

github-actions bot commented Nov 28, 2023

Overall readability score: 54.32 (🟢 +0)

File Readability
supported-languages-and-tools.md 47.27 (🟢 +0)
configuring-code-patterns.md 53.01 (🟢 +0)
security-monitor.md 35.43 (🟢 +0)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
supported-languages-and-tools.md 47.27 31.38 10.83 13.5 15.07 7.83
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
configuring-code-patterns.md 53.01 29.25 9.94 13.3 14.09 6.93
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
security-monitor.md 35.43 19.26 12.76 15.7 15.95 8.48
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0

Averages:

  Readability FRE GF ARI CLI DCRS
Average 54.32 43.22 10.86 12.36 12.52 7.86
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

@nicklem nicklem force-pushed the feat/semgrep-gh-action-scanning branch from fc77ef8 to bee245c Compare November 28, 2023 15:18
@github-actions github-actions bot temporarily deployed to Netlify November 28, 2023 15:19 Inactive
@nicklem nicklem marked this pull request as ready for review November 28, 2023 15:20
@nicklem nicklem requested a review from a team as a code owner November 28, 2023 15:20
@nicklem nicklem self-assigned this Nov 28, 2023
@claudiacarpinteiro
Copy link
Contributor

@nicklem Is any update needed on this table for this Semgrep line? 🤔

@nicklem
Copy link
Contributor Author

nicklem commented Nov 29, 2023

@claudiacarpinteiro It's not technically a language, and the table lists tool configuration files, so I opted not to add it. I'm open to adding something there too. @mrfyda thoughts on mentioning GH action files as a "language" on the supported tool config files as mentioned by Claudia?

@github-actions github-actions bot temporarily deployed to Netlify November 29, 2023 16:35 Inactive
@github-actions github-actions bot temporarily deployed to Netlify December 1, 2023 08:44 Inactive
@github-actions github-actions bot temporarily deployed to Netlify December 6, 2023 09:50 Inactive
@github-actions github-actions bot temporarily deployed to Netlify December 11, 2023 09:30 Inactive
@mrfyda
Copy link
Contributor

mrfyda commented Dec 11, 2023

@claudiacarpinteiro It's not technically a language, and the table lists tool configuration files, so I opted not to add it. I'm open to adding something there too. @mrfyda thoughts on mentioning GH action files as a "language" on the supported tool config files as mentioned by Claudia?

in that table, we already mention AsyncAPI and OpenAPI which I wouldn't consider languages, or at least comparable domain-specific languages to GitHub Actions. I think there are no major risks to listing it as a programing language. 👍

@nicklem nicklem enabled auto-merge (squash) December 11, 2023 15:35
@github-actions github-actions bot temporarily deployed to Netlify December 11, 2023 15:36 Inactive
Copy link
Contributor

@claudiacarpinteiro claudiacarpinteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@nicklem nicklem merged commit 4203683 into master Dec 11, 2023
7 checks passed
@nicklem nicklem deleted the feat/semgrep-gh-action-scanning branch December 11, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants