Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Add instruction bundles #143

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

etodanik
Copy link
Contributor

Tracking the instruction bundles feature progress here.

This adds the following nodes:

  • InstructionBundleNode - an optional array of those sits on each ProgramNode
  • InstructionAccountLinkNode - allows us to link to an instruction account (for overriding)
  • InstructionArgumentLinkNode - allows us to link to an instruction argument (for overriding)
  • InstructionLinkNode - allows us to link to an instruction, to include them in a bundle
  • InstructionAccountOverrideNode - Provides a way to override an account (e.g to provide one account to multiple instructions at once or to set sensible defaults)
  • InstructionArgumentOverrideNode - Provides a way to override an argument (e.g to provide one argument to multiple instructions at once or to set sensible defaults)

There is also a change to AccountLinkNode, PdaLinkNode: An added program?: ProgramLinkNode optional argument (because in the context of having bundles we need to be able to refer to those in other programs). This should be a backwards compatible change since it's optional. The default behavior will be to look in the context of the current program.

Next steps:

  • Nodes & node types
  • Visitors
  • JS Renderer
  • Rust Renderer
  • Nested bundles? (probably in a separate PR)

I'm planning to use createToken & initializeAccount as an example to test again in the renderers.

Copy link

changeset-bot bot commented Jul 30, 2024

⚠️ No Changeset found

Latest commit: 9dba00c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lorisleiva lorisleiva changed the title Add instruction bundles [0.22] Add instruction bundles Aug 19, 2024
@lorisleiva lorisleiva changed the title [0.22] Add instruction bundles [2.x] Add instruction bundles Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant