Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform all u8 arrays by default #362

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

lorisleiva
Copy link
Member

The current behaviour confuses devs because some u8 arrays are being turned into BytesTypeNode but not others based on their size. This PR fixes this by transforming all fixed-size arrays of u8 numbers into a FixedSizeTypeNode of BytesTypeNode.

The current behaviour confuses devs because some `u8` arrays are being turned into `BytesTypeNode` but not others based on their size. This PR fixes this by transforming all fixed-size arrays of `u8` numbers into a `FixedSizeTypeNode` of `BytesTypeNode`.
Copy link

changeset-bot bot commented Dec 23, 2024

🦋 Changeset detected

Latest commit: dd2d5b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@codama/visitors Minor
@codama/nodes-from-anchor Minor
codama Minor
@codama/renderers-js Patch
@codama/renderers Patch
@codama/errors Minor
@codama/node-types Minor
@codama/nodes Minor
@codama/validators Minor
@codama/visitors-core Minor
@codama/dynamic-codecs Patch
@codama/dynamic-parsers Patch
@codama/renderers-core Patch
@codama/renderers-js-umi Patch
@codama/renderers-rust Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lorisleiva lorisleiva marked this pull request as ready for review December 23, 2024 16:41
@lorisleiva lorisleiva merged commit d956af2 into main Dec 27, 2024
4 checks passed
@lorisleiva lorisleiva deleted the loris/transform-all-u8-arrays-by-default branch December 27, 2024 10:49
@github-actions github-actions bot mentioned this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant