CxODEV-459 Conductor: Add support for publishing wf/task events to RabbitMQ #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tymarats
reviewed
Jan 3, 2024
| @@ -127,3 +127,20 @@ management.metrics.export.datadog.enabled=false | |||
| #optional - default Datadog instance is https://app.datadoghq.com/ | |||
| # management.metrics.export.datadog.uri=<your DD instance> | |||
| #management.metrics.export.datadog.step=10s | |||
|
|
|||
| #Following properties set for using for publishing workflow/task status change event to RabbitMQ: | |||
There was a problem hiding this comment.
Style: Looking around, I see that "non-code" comments should have a space between # and the sentence (not unlike our own .NET Coding Conventions)
ognjenkatic
reviewed
Jan 3, 2024
| @Override | ||
| public void onWorkflowTerminatedIfEnabled(WorkflowModel workflow) { | ||
| if (workflow.getWorkflowDefinition().isWorkflowStatusListenerEnabled() | ||
| || rabbitMQProperties.isWorkflowStatusListenerEnabled()) { |
There was a problem hiding this comment.
Maybe we should rename isWorkflowStatusListenerEnabled to something like shouldAlwaysPublishWorkflowStatus sa it more accurately reflects what it does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)Changes in this PR
Support for publishing workflow and task events to external message broker, in this case RabbitMQ, by implementing workflow and task status listeners that are used by workflow executor class. This functionality is enabling a dedicated microservice to actively listen for these updates, subsequently triggering specific actions.
Alternatives considered
--