-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 1.9.0 SteamSharedLibraryLoader as SteamLibraryLoaderLegacy #130
Conversation
Restores the mac & gradle compatible loader from previous versions as a legacy loader. Uses the new SteamLibraryLoader interface
Very useful, thank you. A bit pedantic but I would call it the "LegacyLoader" and not the "LoaderLegacy" since Loader is the noun and Legacy is the adjective, but that's just me. Also it would be great if the "new way of doing things" was documented or explained somewhere. I'm not keen on writing my own loader just to boost to version 1.10 and this LegacyLoader is most convenient to me at the moment. I do not use LWJGL3 |
loader/legacy/src/main/java/com/codedisaster/steamworks/SteamLibraryLoaderLegacy.java
Outdated
Show resolved
Hide resolved
It matches the existing naming pattern set by SteamLibraryLoaderGdx, and SteamLibraryLoaderLwjgl. I don’t know the original reason, but I would guess it’s so IDE autocomplete shows all the options.
Yea, writing a loader feels out of scope for projects using steamworks4j. It’s not like writing a callback to use the library, it’s writing an essential piece of the library itself. I do appreciate the new loader interface, and think it's great that loading can be customized to match the frameworks people are using. However, I think the library should still have a default loader. I’m assuming updated docs will come with the official 1.10.0 release. |
I tried and this legacy loader is the only one that works on Mac OS with M1/M2 CPU! I also propose +1 to have this added back. Given, this is old, maybe we can add a |
Thanks for trying it out. Stoked to see it works on new Macs as well. Agree on |
Found a better solution for loading the libraries on macOS. Closing this. |
Adds the original loader as a legacy loader module.
The old loader works with mac with gradle where gdx, and lwjgl3 currently do not.
The changes to the old loader are minimal, just enough to implement the
SteamLibraryLoader
interface.Tested on Windows, Intel Mac, and Linux.