Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some updates for version 1.1.5 #37

Merged
merged 19 commits into from
Apr 27, 2020
Merged

Some updates for version 1.1.5 #37

merged 19 commits into from
Apr 27, 2020

Conversation

williamdes
Copy link
Member

@williamdes williamdes commented Apr 18, 2020

@williamdes
Copy link
Member Author

@kayahr I made https://github.com/williamdes/jquery-fullscreen-plugin/tree/npm/1.1.4 so you could npm publish the version

And I hope my changes are okay, If so you can merge my pull-request and all the other ones will be merged.
It is ready for a npm publish of 1.1.5.

https://www.npmjs.com/package/jquery-fullscreen-plugin

@williamdes
Copy link
Member Author

@kayahr 🏓 If you did have a chance to see my PR ?

@kayahr
Copy link
Contributor

kayahr commented Apr 27, 2020

Sorry for the late answer. Well... the problem is... This project is pretty old, I haven't used jquery and this plugin for years. So I'm not really able to check the pull request as you (who is still using jquery and this plugin) have now more know how about the topic then I have (or ever had).

Are you interested in taking over the project? I would be glad to transfer it to you.

@williamdes
Copy link
Member Author

Sorry for the late answer. Well... the problem is... This project is pretty old, I haven't used jquery and this plugin for years. So I'm not really able to check the pull request as you (who is still using jquery and this plugin) have now more know how about the topic then I have (or ever had).

Are you interested in taking over the project? I would be glad to transfer it to you.

Yeah, sure
Could you also give me access to https://www.npmjs.com/package/jquery-fullscreen-plugin ?

@kayahr
Copy link
Contributor

kayahr commented Apr 27, 2020

Transfer failed because your account already has a fork of the project obviously. Could you rename your copy first? And I can't give you access to the NPM package because it wasn't me who uploaded it. I don't know the guy who did.

@williamdes
Copy link
Member Author

Transfer failed because your account already has a fork of the project obviously. Could you rename your copy first? And I can't give you access to the NPM package because it wasn't me who uploaded it. I don't know the guy who did.

Done ;)

@williamdes
Copy link
Member Author

And I can't give you access to the NPM package because it wasn't me who uploaded it. I don't know the guy who did.

I will have to contact him ..

@kayahr
Copy link
Contributor

kayahr commented Apr 27, 2020

Still doesn't work because of your fork. Well, I still like to transfer it so github automatically redirects requests to the old repository to the new one... Hm... Well, I guess your first action is merging the PR anyway so I'll do that now, then you can remove your fork and then I hope I can transfer it.

@kayahr kayahr merged commit 108a857 into code-lts:master Apr 27, 2020
@williamdes
Copy link
Member Author

Could you transfer it to @code-lts ?

@williamdes
Copy link
Member Author

I created this organisation to hold packages for a long term support, so I can give the hand to someone else in some years of needed

@kayahr
Copy link
Contributor

kayahr commented Apr 27, 2020

Transfer worked now after merging the PRs. I guess you have to accept the transfer now? I never transfered a project to someone else :)

@kayahr
Copy link
Contributor

kayahr commented Apr 27, 2020

It worked! Great. Well, thanks for taking over, I hope the project is in good hands. Treat it well and be nice to it, jQuery can be quirky from time to time ;-)

@williamdes
Copy link
Member Author

Thank you !
It worked fine after I accepted it, I also invited you to @code-lts that I will improve

@williamdes williamdes mentioned this pull request Apr 27, 2020
@williamdes williamdes self-assigned this Apr 27, 2020
williamdes added a commit that referenced this pull request Apr 27, 2020
@williamdes williamdes changed the title Some updates for version 1.1.6 Some updates for version 1.1.5 May 29, 2020
@williamdes williamdes added this to the 1.1.5 milestone May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants