-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some updates for version 1.1.5 #37
Conversation
@kayahr I made https://github.com/williamdes/jquery-fullscreen-plugin/tree/npm/1.1.4 so you could npm publish the version And I hope my changes are okay, If so you can merge my pull-request and all the other ones will be merged. |
@kayahr 🏓 If you did have a chance to see my PR ? |
Sorry for the late answer. Well... the problem is... This project is pretty old, I haven't used jquery and this plugin for years. So I'm not really able to check the pull request as you (who is still using jquery and this plugin) have now more know how about the topic then I have (or ever had). Are you interested in taking over the project? I would be glad to transfer it to you. |
Yeah, sure |
Transfer failed because your account already has a fork of the project obviously. Could you rename your copy first? And I can't give you access to the NPM package because it wasn't me who uploaded it. I don't know the guy who did. |
Done ;) |
I will have to contact him .. |
Still doesn't work because of your fork. Well, I still like to transfer it so github automatically redirects requests to the old repository to the new one... Hm... Well, I guess your first action is merging the PR anyway so I'll do that now, then you can remove your fork and then I hope I can transfer it. |
Could you transfer it to @code-lts ? |
I created this organisation to hold packages for a long term support, so I can give the hand to someone else in some years of needed |
Transfer worked now after merging the PRs. I guess you have to accept the transfer now? I never transfered a project to someone else :) |
It worked! Great. Well, thanks for taking over, I hope the project is in good hands. Treat it well and be nice to it, jQuery can be quirky from time to time ;-) |
Thank you ! |
Merged Updating version number in manifest #23
Merged Add CDNJS version badge in readme #29
Merged Updated minified version #33
Merged Prevent TypeError: Document not active - fixes #34 #35
Some minor improvements