🐛 fix: Fix changelog fetch fail (fix lobehub#5187) (lobehub#5189)

code · Dec 26, 2024 · 5ad66a6 · 5ad66a6
1 parent 26216ce
commit 5ad66a6
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 6 deletions.
diff --git a/src/app/(main)/changelog/page.tsx b/src/app/(main)/changelog/page.tsx
@@ -38,6 +38,8 @@ const Page = async () => {
   const changelogService = new ChangelogService();
   const data = await changelogService.getChangelogIndex();
 
+  if (!data) return notFound();
+
   const ld = ldModule.generate({
     description: t('changelog.description', { appName: BRANDING_NAME }),
     title: t('changelog.title', { appName: BRANDING_NAME }),
@@ -48,7 +50,7 @@ const Page = async () => {
     <>
       <StructuredData ld={ld} />
       <Flexbox gap={mobile ? 16 : 48}>
-        {data.map((item) => (
+        {data?.map((item) => (
           <Fragment key={item.id}>
             <Suspense
               fallback={

diff --git a/src/app/@modal/(.)changelog/modal/page.tsx b/src/app/@modal/(.)changelog/modal/page.tsx
@@ -20,9 +20,11 @@ const Page = async () => {
   const changelogService = new ChangelogService();
   const data = await changelogService.getChangelogIndex();
 
+  if (!data) return notFound();
+
   return (
     <>
-      {data.map((item) => (
+      {data?.map((item) => (
         <Suspense fallback={<Loading />} key={item.id}>
           <Post locale={locale} mobile={mobile} {...item} />
         </Suspense>

diff --git a/src/features/ChangelogModal/index.tsx b/src/features/ChangelogModal/index.tsx
@@ -7,11 +7,17 @@ import { memo } from 'react';
 import { useGlobalStore } from '@/store/global';
 
 const ChangelogModal = memo<{ currentId?: string }>(({ currentId }) => {
-  const latestChangelogId = useGlobalStore((s) => s.status.latestChangelogId);
+  const [latestChangelogId, updateSystemStatus] = useGlobalStore((s) => [
+    s.status.latestChangelogId,
+    s.updateSystemStatus,
+  ]);
   const router = useRouter();
 
   useTimeout(() => {
-    if (latestChangelogId !== currentId) {
+    if (!currentId) return;
+    if (!latestChangelogId) {
+      updateSystemStatus({ latestChangelogId: currentId });
+    } else if (latestChangelogId !== currentId) {
       router.push('/changelog/modal');
     }
   }, 1000);

diff --git a/src/features/User/UserPanel/useMenu.tsx b/src/features/User/UserPanel/useMenu.tsx
@@ -188,7 +188,7 @@ export const useMenu = () => {
     {
       icon: <Icon icon={FileClockIcon} />,
       key: 'changelog',
-      label: <Link href={'/changelog'}>{t('changelog')}</Link>,
+      label: <Link href={'/changelog/modal'}>{t('changelog')}</Link>,
     },
     {
       children: [

diff --git a/src/server/services/changelog/index.ts b/src/server/services/changelog/index.ts
@@ -54,7 +54,7 @@ export class ChangelogService {
       return this.mergeChangelogs(data.cloud, data.community).slice(0, 5);
     } catch (e) {
       console.error('Error getting changelog lists:', e);
-      return false as any;
+      return [];
     }
   }