Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Don't serialize chunk ids for Hint and Console rows (facebook#31671)
Hints and Console logs are side-effects and don't belong to any particular value. They're `void`. Therefore they don't need a row ID. In the current parsing scheme it's ok to omit the id. It just becomes `0` which is the initial value which is then unused for these row types. So it looks like: ``` :HP[...] :W[...] 0:{...} ``` We could patch the parsing to encode the tag in the ID so it's more like the ID is the target of the side-effect. ``` H:P[...] W:[...] 0:{...} ``` Or move the tagging to the beginning like it used to be. But this seems simple enough for now.
- Loading branch information