Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from facebook:main #47

Merged
merged 4 commits into from
Dec 19, 2024
Merged

[pull] main from facebook:main #47

merged 4 commits into from
Dec 19, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented Dec 19, 2024

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

rickhanlonii and others added 4 commits December 18, 2024 14:45
…f reportGlobalError (#31840)

We might have already resolved models that are not pending and so are
not rejected by aborting the stream. When those later get parsed they
might discover new chunks which end up as pending. These should be
errored since they will never be able to resolve later.

This avoids infinitely hanging the stream.

This same fix needs to be ported to ReactFlightClient that has the same
issue.
This is enabled everywhere, we can just use the inline `__DEV__` checks.
@pull pull bot added the ⤵️ pull label Dec 19, 2024
@pull pull bot merged commit faf6c4d into code:main Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants