Skip to content

fix legal hold/API client bug in devices command #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 18, 2023

Conversation

timabrmsn
Copy link
Contributor

When running code42 devices list --include-legal-hold-membership with an API client profile, the CLI wasn't accounting for the different response type returned from the new API client-supported endpoint, and users would get this error in the logs:

py42.exceptions.Py42Error: The Py42Response root is of type <class 'list'>, but __getitem__ got a key of legalHolds, which is incompatible.

@timabrmsn timabrmsn requested a review from tora-kozic December 8, 2022 20:06
@timabrmsn timabrmsn merged commit 24c11c9 into main Jan 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2023
@tora-kozic tora-kozic deleted the bugfix/devices_list_w_legal_hold_api_client branch November 30, 2023 21:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants