Finished tasks 38, 37, 36 #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warrenwwang1
approved these changes
May 2, 2021
| @@ -22,11 +22,13 @@ function Dashboard() { | |||
| let proposal_lst = response.data; | |||
| /* Initialize false <checked> attributes for each proposal; used for checkbox tracking | |||
| while in deleting mode */ | |||
| console.log("proposals fetched " + proposal_lst) | |||
| proposal_lst.forEach(proposal => { | ||
| proposal_lst.checked = false; | ||
| }) | ||
| setProposals(proposal_lst); | ||
| setFilteredProposalsList(proposal_lst); | ||
| firstProposal(proposal_lst); |
There was a problem hiding this comment.
maybe rename func to "setPreviewToFirstProposal" bc its not clear what "firstProposal" does
| @@ -11,17 +11,24 @@ function ConditionalUserNameRender(isAdmin, userName) { | |||
| } | |||
| } | |||
|
|
|||
| function ConditionalUserDisplay(userID) { | |||
| console.log(userID); | |||
Comment on lines
+156
to
+161
| if (proposal.checked) { | ||
| updatedPropsIdsToDelete.pop(proposal.id); | ||
| } | ||
| else { | ||
| updatedPropsIdsToDelete.push(proposal.id); | ||
| } |
There was a problem hiding this comment.
just wanted to comment that this is beautiful :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Note task 35 is not included in this.
Issue #36 #37 #38
Summary of Changes
Feel free to use sentences or a bulleted list.
Testing
Manual Testing
Screenshot/Gif of results