google login #10
Open
google login #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 4, 2023 22:28
KyPT2503
reviewed
Sep 7, 2023
| c.Redirect(http.StatusFound, url) | ||
| } | ||
|
|
||
| func (b *AuthController) GoogleCallback(c *gin.Context) { |
There was a problem hiding this comment.
callback thường thêm param state để validate request này
KyPT2503
reviewed
Sep 7, 2023
models/user.go
Outdated
| @@ -4,9 +4,9 @@ type User struct { | |||
| BaseModel | |||
| FirstName string `json:"first_name" gorm:"column:first_name;type:varchar(50);not null"` | |||
| LastName string `json:"last_name" gorm:"column:last_name;type:varchar(50);not null"` | |||
| Email string `json:"email" gorm:"column:email;type:varchar(100);not null"` | |||
| Email string `json:"email" gorm:"column:email;type:varchar(100);not null; unique"` | |||
There was a problem hiding this comment.
cái email khi login thường, fb, google nó sẽ bị trùng email này. Trước team PO chốt là nếu đăng nhập bằng các phương thức khác nhau thì sẽ tạo ra 3 tài khoản khác nhau, nên mình sẽ không index unique ở chỉ email mà mình sẽ đánh index composite unique 2 column email vs social luôn
added 2 commits
September 19, 2023 22:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.