Add ~~non upstreamable~~ opinionated modifications #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inaki-amatria
requested review from
daniel-otero and
alvrogd
and removed request for
a team
daniel-otero
approved these changes
Mar 19, 2025
This commit must be removed now that we have semantic access to parent nodes!!
These `alias`es are meaningless and may provoke duplicate visitations for third-party applications.
inaki-amatria
force-pushed
the
feature/AddUpstreamableChanges
branch
from
f0f4186 to
f17e804
Compare
inaki-amatria
force-pushed
the
feature/AddNonUpstreamableChanges
branch
from
632f857 to
e75737f
Compare
inaki-amatria
changed the title
I changed the PR title and description to show these are opinionated commits! TYSM for the quick review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates our
non upstreamableopinionated modifications intotree-sitter-fortran. I have made an effort to preserve the original authorship of the commits, so please review this information carefully to ensure proper attribution (and, of course, accountability 😁).