Merge pull request #1398 from codeforboston/main

Deploy to prod

.github/ISSUE_TEMPLATE/Actionable_Ticket.md

@@ -0,0 +1,42 @@
+---
+name: Actionable Item Ticket
+about: Create a scoped ticket with context
+title: ""
+labels: ""
+assignees: ""
+---
+
+**Summary**  
+Briefly describe the end product of this ticket, its place in the project, and why it is needed.
+
+**Work Detail**  
+Describe in detail the work to be done for this ticket
+
+- Frontend: Add links to the relevant components in Figma
+- Backend: Specify what services will be used and how to get credentials if needed
+- Any required skills or knowledge
+
+**Current State**  
+Describe any previous related or similar work in this area
+
+- Add the file paths to the involved files or folders
+- Link to related tickets & describe their relationship
+- Describe any dependencies or blockers
+
+**Resources**  
+Provide resources relevant to this ticket
+
+- File paths to components, hooks, etc. that might be used directly or as a guide
+- File paths to files that might be touched or referenced
+- Links to the website/docs for services being used (e.g. firebase)
+
+**Add labels**  
+front end | backend | full stack  
+good first issue | required skill or knowledge
+
+**Checklist**
+
+1. Check to ensure this is not a duplicate ticket
+2. Add the appropriate labels
+3. Add the appropriate Zenhub Epic
+4. If this a front-end dev ticket, ensure the relevant figma is linked

.github/ISSUE_TEMPLATE/Feature.md

@@ -0,0 +1,24 @@
+---
+name: New Feature Suggestion
+about: Suggest an idea for a new feature
+title: ""
+labels: new-feature
+assignees: ""
+---
+
+**Feature Title**
+A clear and concise title for what the feature is.
+
+**Detailed Description**
+A detailed description of the feature you're suggesting.
+
+**Reason for the Suggestion**
+Explain why this feature would be useful and what problem it would solve.
+
+**Additional Context**
+Add any other context or screenshots about the feature request here.
+
+**Checklist**
+
+- [ ] I have checked if this feature is not already requested
+- [ ] I have explained the feature in detail

.github/ISSUE_TEMPLATE/Feature_Enhancement.md

@@ -0,0 +1,24 @@
+---
+name: Feature Enhancement Suggestion
+about: Suggest an enhancement for an existing feature
+title: ""
+labels: enhancement
+assignees: ""
+---
+
+**Suggestion Title**
+A clear and concise title for what the enhancement is.
+
+**Detailed Description**
+A detailed description of the enhancement you're suggesting.
+
+**Reason for the Suggestion**
+Explain why this enhancement would be useful and what problem it would solve.
+
+**Additional Context**
+Add any other context or screenshots about the feature enhancement here.
+
+**Checklist**
+
+- [ ] I have checked if this enhancement is not already suggested
+- [ ] I have explained the enhancement in detail

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,40 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: ""
+labels: bug
+assignees: ""
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Actual Results + Screenshots**
+Describe what happened, and if applicable, add screenshots to help explain your problem.
+
+**Desktop (please complete the following information):**
+
+- OS: [e.g. iOS]
+- Browser [e.g. chrome, safari]
+- Version [e.g. 22]
+
+**Smartphone (please complete the following information):**
+
+- Device: [e.g. iPhone6]
+- OS: [e.g. iOS8.1]
+- Browser [e.g. stock browser, safari]
+- Version [e.g. 22]
+
+**Additional context**
+Add any other context about the problem here.

.github/workflows/deploy-backend-dev.yml

@@ -22,7 +22,7 @@ jobs:
       - name: Setup Build Environment
         uses: ./.github/actions/setup-repo
       - name: Build and Deploy to Firebase
-        uses: w9jds/firebase-action@master
+        uses: w9jds/firebase-action@v12.9.0
         with:
           args: deploy --force --only firestore,functions,storage
         env:

.github/workflows/deploy-prod.yml

@@ -16,7 +16,7 @@ jobs:
       - name: Setup Build Environment
         uses: ./.github/actions/setup-repo
       - name: Build and Deploy to Firebase
-        uses: w9jds/firebase-action@master
+        uses: w9jds/firebase-action@v12.9.0
         with:
           args: deploy --force --only firestore,functions,storage
         env:

components/EditProfilePage/PersonalInfoTab.tsx

@@ -115,6 +115,10 @@ export function PersonalInfoTab({
             <Input
               label={t(isOrg ? "forms.orgName" : "forms.fullName")}
               {...register("fullName", {
+                value: fullName?.trim(),
+                validate: value =>
+                  value.trim().length >= 2 ||
+                  t("forms.errEmptyAndMinLength").toString(),
                 required: t(
                   isOrg ? "forms.errOrgNameRequired" : "forms.errNameRequired"
                 ).toString()

components/auth/OrgSignUpModal.tsx

@@ -125,6 +125,9 @@ export default function OrgSignUpModal({
                   label={t("orgName")}
                   type="text"
                   {...register("fullName", {
+                    validate: value =>
+                      value.trim().length >= 2 ||
+                      t("errEmptyAndMinLength").toString(),
                     required: t("nameIsRequired") ?? "A full name is required."
                   })}
                   error={errors.fullName?.message}

components/auth/UserSignUpModal.tsx

@@ -114,6 +114,9 @@ export default function UserSignUpModal({
                   label={t("fullName")}
                   type="text"
                   {...register("fullName", {
+                    validate: value =>
+                      value.trim().length >= 2 ||
+                      t("errEmptyAndMinLength").toString(),
                     required: t("nameIsRequired") ?? "A full name is required."
                   })}
                   error={errors.fullName?.message}

components/search/testimony/TestimonyHit.tsx

@@ -32,11 +32,12 @@ const TestimonyResult = ({ hit }: { hit: Hit<Testimony> }) => {
   const { loading, error, result: bill } = useBill(hit.court, hit.billId)
   const committee = bill?.currentCommittee
   const isOrg = hit.authorRole === "organization"
-  const writtenBy = isOrg ? (
-    <Link href={`/profile?id=${hit.authorUid}`}>{hit.authorDisplayName}</Link>
-  ) : (
-    hit.authorDisplayName
-  )
+  const writtenBy =
+    isOrg || hit.authorDisplayName !== "<private user>" ? (
+      <Link href={`/profile?id=${hit.authorUid}`}>{hit.authorDisplayName}</Link>
+    ) : (
+      hit.authorDisplayName
+    )
   return (
     <div
       style={{

public/locales/en/auth.json

@@ -23,6 +23,7 @@
   "orgName": "Organization Name",
   "fullName": "Full Name",
   "nameIsRequired": "A full name is required",
+  "errEmptyAndMinLength": "Should have at least two characters",
   "selectOrgCat": "Select an organization category",
   "passwordRequired": "A password is required.",
   "passwordLength": "Your password must be 8 characters or longer.",

public/locales/en/editProfile.json

@@ -57,6 +57,7 @@
         "makePrivate": "Make Private",
         "errNameRequired": "Name is required",
         "errOrgNameRequired" : "Organization Name is required",
+        "errEmptyAndMinLength": "Should have at least two characters",
         "aboutYou": "Write something about yourself",
         "aboutYouTip":"What should you write?",
         "selectOrgCategory": "Select an organization cateogry",