-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bill detail reporting #1325
Feature/bill detail reporting #1325
Conversation
@MarkTrepanier is attempting to deploy a commit to the Maple Testimony Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
]} | ||
/> | ||
)} | ||
{/* */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, could you elaborate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just on line 72, there's just an empty comment, so I didn't know if you wanted to write something there, or maybe I'm just missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! yes. My apologies. I had used that to point out the end of {/Report Modal/}
I should have removed it or made it more clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries! Just wanted to make sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, I appreciate it
Hola - status update on this? @MarkTrepanier |
Hiyo. sorry. I've been in the middle of moving, and between that and work, I haven't had the time to update this branch. I have to merge current dev to my branch and it should should be gold. I just haven't been able to sit at my dev computer |
@MarkTrepanier ok thanks. No worries and no rush, just wanted to see where it's at. |
…into feature/bill-detail-reporting
This PR adds the testimony reporting feature to the policy actions component, visible on the Bill Detail page.
I implemented the Report functionality from TestimonyCard, including the toast which displays success over time.
The functionality requires a Testimony object that is not exactly present, so I included "Revision" to be pulled from the useCurrentTestimonyDetails hook.
Within PolicyActions, I have made changes to the definition to the PolicyActionsProps interface to allow the isReporting state and setReporting function. This allows for the report PolicyAction button to use the Report functions.
![Screenshot 2023-09-28 134250](https://private-user-images.githubusercontent.com/88287632/271373257-4209513a-cf4e-4fd6-bd42-23001664348c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NjI0NjEsIm5iZiI6MTczOTQ2MjE2MSwicGF0aCI6Ii84ODI4NzYzMi8yNzEzNzMyNTctNDIwOTUxM2EtY2Y0ZS00ZmQ2LWJkNDItMjMwMDE2NjQzNDhjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDE1NTYwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJmYjhhNjlkOGRhZTljYzZlZmQzM2MwNzY0ZTFmY2Y1YTlhMTg2ZDI1NTE3NTg5NDZmZGI4ZjY5ODYxMGI5YWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.P8kIb_bZ8vPfq5gQkgN-NYr0lDA_XKBQGAnhLnlX8Kc)
![Screenshot 2023-09-28 134333](https://private-user-images.githubusercontent.com/88287632/271373289-83e21341-c31b-4aef-96f7-85f6198c4c2d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NjI0NjEsIm5iZiI6MTczOTQ2MjE2MSwicGF0aCI6Ii84ODI4NzYzMi8yNzEzNzMyODktODNlMjEzNDEtYzMxYi00YWVmLTk2ZjctODVmNjE5OGM0YzJkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEzVDE1NTYwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWEzMGY1YWRjN2QzZmRkNzc4NzM0NGNhNzMyMzRhMjhkOTg2ODE3ZThiZGU2MTAzNTcwNDc5ODU1OGMwMDE4ZGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.qCmw3OLED-u-Qxh8fX6UYwQ7GTMZ7kxhWWKDEWVSJdU)
I have not been able to see the outcome on the back end other than the success toast.