Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bill detail reporting #1325

Merged

Conversation

MarkTrepanier
Copy link
Collaborator

This PR adds the testimony reporting feature to the policy actions component, visible on the Bill Detail page.

I implemented the Report functionality from TestimonyCard, including the toast which displays success over time.
The functionality requires a Testimony object that is not exactly present, so I included "Revision" to be pulled from the useCurrentTestimonyDetails hook.

Within PolicyActions, I have made changes to the definition to the PolicyActionsProps interface to allow the isReporting state and setReporting function. This allows for the report PolicyAction button to use the Report functions.
Screenshot 2023-09-28 134250
Screenshot 2023-09-28 134333

Screenshot 2023-09-28 134355

I have not been able to see the outcome on the back end other than the success toast.

@vercel
Copy link

vercel bot commented Sep 28, 2023

@MarkTrepanier is attempting to deploy a commit to the Maple Testimony Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2023 4:16pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
maple-prod ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2023 4:16pm

]}
/>
)}
{/* */}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing comment?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, could you elaborate?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just on line 72, there's just an empty comment, so I didn't know if you wanted to write something there, or maybe I'm just missing something.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! yes. My apologies. I had used that to point out the end of {/Report Modal/}
I should have removed it or made it more clear

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! Just wanted to make sure.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, I appreciate it

@mvictor55
Copy link
Collaborator

Hola - status update on this? @MarkTrepanier

@MarkTrepanier
Copy link
Collaborator Author

Hiyo. sorry. I've been in the middle of moving, and between that and work, I haven't had the time to update this branch. I have to merge current dev to my branch and it should should be gold. I just haven't been able to sit at my dev computer

@mvictor55
Copy link
Collaborator

@MarkTrepanier ok thanks. No worries and no rush, just wanted to see where it's at.

@sashamaryl sashamaryl merged commit 119f116 into codeforboston:main Dec 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants