-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fix #1383
bug fix #1383
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@mertbagt did the above errors occur during the vercel deployment? |
yea, if you click on details, you can pull up the deployment overview to see all the logs. although, I see the same warnings on my local review copy of this branch in my ide I got some minor errors displaying the relevant page when I tried to run the app, but I think those will go away when the above issue is resolved. |
okay, squashed I believe! |
awesome, that cleaned up the compiling errors. however, I'm not getting the testimony counter (i.e. there are X - Y out of Z) but instead "There are no testimonies" when there are in fact testimonies for the account in question. I get this with both the deployment and running the code locally. Whenever I navigate to "View Profile", I get this on my local console: I'm wondering if it could be an issue with one of my testing accounts vs, an issue with firebase. If you hit View Deployment on this PR, are you able to get the testimony counter to display properly on your end? I'm going to reach out to one of the devs more familiar with firebase to see what they think, |
Ah yes, I saw that error before and believe it has to do with firebase credentials. I had to generate a new secret key in firebase and then save it within .env.local in order to get past the error. I think this section in countTestimonies:
needs to be set to the correct firebase credentials for the production server and then it should work |
@mertbagt were you able to connect with any of the other firebase maple devs? |
Yea, I was going over it with @sashamaryl yesterday and she's looking into it. |
great! |
Summary
Add a short summary of the changes, and a reference to the original issue using
#
and the issue number, like #1I added a countTestimonies function that gets the total count of testimonies per user and integrated that into the view testimony component so that you are able to get a count of the how many testimonies each user has published when on the profile page of the user.
Screenshots
Known issues
As I discussed with Matt, we should ensure that the total testimonies count is accurately updated when you delete a testimony as well.
Steps to test/reproduce