Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix following button #1653

Merged
merged 7 commits into from
Dec 4, 2024
Merged

Conversation

mertbagt
Copy link
Collaborator

@mertbagt mertbagt commented Nov 27, 2024

Summary

replaces the following button for Org - Profile Page to use the working follow button from user testimony

this PR should be used to overwrite anything overlapping from PR 1651

Known Issues:

  1. the functioning follow button store type as "testimony" on the backend, but the record doesn't have anything to do with following specific testimonies. It just happens to have been used by the Search Testimony page. It probably ought to be type: "user" but renaming it will need very careful review to avoid missing a reference and breaking things

2) At some point, should go through and delete the "bad" old follow button code to disambiguate.

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 11:31pm

@mertbagt mertbagt merged commit 0afeb59 into codeforboston:main Dec 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants