Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used query instead of function in Firebase #1675

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

kiminkim724
Copy link
Collaborator

Summary

Closes #1666

  • Changed the EditProfilePage Unfollow buttons to use direct queries instead of calling firebase functions, improving latency

Checklist

  • On the frontend, I've made my strings translate-able.
  • If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.

Screenshots

Add some screenshots highlighting your changes.

Known issues

If you've run against limitations or caveats, include them here. Include follow-up issues as well.

Steps to test/reproduce

For each feature or bug fix, create a step by step list for how a reviewer can test it out. E.g.:

  1. Go to Following tab and try to unfollow
  2. The changes should be instant

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 11:52pm

@mertbagt
Copy link
Collaborator

much improved 🚀 🚀 🚀

giphy (2)

@mertbagt mertbagt merged commit df1cdd7 into codeforboston:main Jan 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Unfollow Button Lag on Profile Page
2 participants