Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 style copy updates #1680

Merged
merged 7 commits into from
Jan 22, 2025
Merged

Conversation

aaerhart
Copy link
Collaborator

Summary

#1670

Checklist

  • On the frontend, I've made my strings translate-able.
  • If I've added shared components, I've added a storybook story.
  • I've made pages responsive and look good on mobile.

Screenshots

Add some screenshots highlighting your changes.

Known issues

If you've run against limitations or caveats, include them here. Include follow-up issues as well.

Steps to test/reproduce

  1. Go to a Bill Detail page and first link under Learn

Copy link

vercel bot commented Jan 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maple-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 2:19am
maple-prod 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 2:19am

Copy link
Collaborator

@Mephistic Mephistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good - just a few minor notes!

components/bill/SmartDisclaimer.tsx Show resolved Hide resolved
components/bill/redux.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@Mephistic Mephistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mephistic Mephistic merged commit 96b5114 into codeforboston:main Jan 22, 2025
7 checks passed
Mephistic added a commit that referenced this pull request Jan 28, 2025
* Create adminPage test

* Admin account sign in

* Setup login to admin account and create no user report test

* Setting admin account

* Update yarn.lock adn package.json

* Add icon display test

* Add e2e test for admin page

* Add sorting, user reports and upgrade requests page test

* Merged with upstream main

* modified follow button to prevent navigating to another page

* Make test serial and rewrite reslove report test

* LLM summarization and tagging features added

* Added readme.md file

* fixed follow button to accurately show following or not

* Remove setup from playwright congig and delte the auth file

* Run prettier

* Update llm/demo_app_functions.py

Co-authored-by: Nathan E. Sanders <[email protected]>

* Update llm/demo_app_functions.py

Co-authored-by: Nathan E. Sanders <[email protected]>

* Update llm/readme.md

Co-authored-by: Nathan E. Sanders <[email protected]>

* Update llm/readme.md

Co-authored-by: Nathan E. Sanders <[email protected]>

* Update llm/readme.md

Co-authored-by: Nathan E. Sanders <[email protected]>

* Update llm/readme.md

Co-authored-by: Nathan E. Sanders <[email protected]>

* Merged changes from remote to local

* Changed the file names as per code review

* Added necessary instrcutions for openAI API key

* Updated requirements.txt file

* Move the credentials to .env

* fixed the follow button on the bill details page

* Adding topics to bills to prep for LLM data, Hard-coding the category -> topic map because that should be frozen as a product decision, Updating search indexing for bills to hydrate topic categories and properly format the bill topics so they can be used in the front-end by the Instantsearch hierarchical menu widget

* Added python version in readme.md file

* Added more detailed explanation on why we chunk with a length of 2000

* Updating topics and categories to reflect the finalized assignments, making capitalization consistent across topics, making topics an optional field across both Bill data types

* Extracting category/topic building to helper function, fixing type error

* Adding base summary field to bill models

* Adding kiminkim724 as CODEOWNER

* Add .env.example and Updated README with instructions

* Update README

* Update README

* Extracting PaginationButtons for translation

* Extracting translatable strings from HearingsScheduled component

* Extracting translation strings from Legislative Process learn page

* Extracting strings from Testimony Panel CTAs

* Extracting translation strings for YourTestimony component

* Extracting strings for translation for ThankYouModal

* Using translated string for EditTestimonyButton tooltip

* Extracting translation strings from SubmitTestimonyForm

* Extracting translatable strings from ChooseStance component

* Extracting translatable strings for SelectLegislatorsCta component

* Extracting translatable strings for KeepNote component

* Extracting translatable strings from WriteTestimony component in publish flow

* Capitalizing all headers for legislative process learn page per PR feedback

* Update publishNotifications to include Bill History Updates

* Added 2 new API functions, one to generate summaries and tags using summaries combined and the second one is to generate only tags using summaries

* Updated prettierignore to ignore llm directory for Prettier check

* Bill Topic Updates (#1647)

* Switching bill topic format per dev feedback, extracting topic parser for later use, adding unit tests for topic parser

* Prettier fixes

* Llm bill summary (#1645)

* initial dividers

* translations for literal strings

* update common.json

* mobile sizing for smart summary

* smart disclaimer

* feature flagging

* smart tags

* mobile pruning

* cleanup

* cleaned up old court banner translation

* added icon files

* remaining icons

* nowrap enforced on SmartTagButton to fix firefox issue

* switch smart-summary image from png to svg and moved to subfolder

* cleanup common.json

* translation

* navigation

* footer

* added auth translation file to newsfeed page

* adjust filter positioning

* newsfeed bill card work

* bill card almost done

* polished newsfeed bill card

* enable follow organizations tab display

* userLookup

* Create notificationEvent on BillHistory Updates (#1648)

* Create notificationEvent on BillHistory Updates

* Add authorUid

* Updated Notification types to be more explicit with possible undefined fields

* Add useState

* fix following button

* isBillMatch

* reminder to clean out old code

* cleanup

* upgrade Profile page to use new follow context

* cleanup

* change Orgs -> Users You Follow

* renamed components

* update stories to new naming scheme

* testimony card title

* cleanup

* fixed broken Bill Updates filter

* testimony card body basic

* cleaned up NewsfeedCard

* fixed stories

* mobile spacing

* adjust mobile breakpoint

* cleanup

* refactored CardTitle using switch

* Update firestore indexes to include topicName

* Added notification fields on back-end to supply more information to Newsfeed

* Make the Notification types more explicit for Testimony vs Bill History notifications (#1659)

* Make the notification return type more explicit

* Added billId field to types

* Fix lint

* Revert ignoreUndefinedProperties

* updated testimony author link

* cleanup

* cleanup props

* prop cleanup

* bill notifications updated

* replaced header with billId on CardTitleFollowing

* more cleanup

* updated stories

* polish

* translations

* Follow btn individual users (#1654)

* feat: follow buttons for individual users

* fix: remove second follow user button

* fix: user cannot follow their own testimony hit

* fix: rn prettier

* link to Edit Profile - Following Tab

* mobile nav link

* cleanup

* removed useless code line

* removed more useless code

* fixed mobile nav double light up bug

* dev comments

* combined navbar files

* move social info to own row

* added FollowedContent and YourTestimonies buttons

* connected SettingsModal to View Profile page

* recolored buttons

* bug fix

* cleaned up integration tests

* updated stories

* deactivated ProfileHeader story - to be updated later

* updated ProfileSettingsModal story

* updated personalInfoTal.stories

* updated EditProfilePage.stories

* cleanup

* fixed modal not updating after save

* cleanup

* cleanup

* fixed Edit Profile button to link to correct tab

* deactivated outdated stories

* resized Edit Profile button

* fix: hide follow btn for logged out users bill detail pg

* Used query instead of function in Firebase

* Remove unused imports and functions

* fix: ran prettier

* count fixed (#1673)

* count fixed

* Forgot to commit changes before push

* 1607 add llm genrated tag (#1655)

* add hierarchicalMenu(fake data)

* Update HierarchialMenu

* Update menu with llm data

* Create useHierarchicalMenu and fix add padding to the left of child

* Craete a customize HierarchicalMenuWidget

* update css for llm tag menu

* Delete the parent counting and sort parent Alphabetical

* Baypass typesense error

* Delete the algoliasearch dependncy

* Add Col to testimony Search

* Add refinement

* Implement sorting logic for llm tags display

* Extract the subtitle for filter tags

* Add updated facets into getItems and remove redinment from useHierarachicalMenu

* Run prettier

* Change the iteration and detelet the downlevelIteration

* Add filter to getWidgetSearchParameter

* Newsfeed Content Buttons (#1672)

* newsfeed content buttons

* repositioned newsfeed buttons

* added prop on ProfileHeader

* added / to image src (#1678)

* added / to image src

* cleanup

* typo

* feat: bill follow and unfollow functionality to testimony page (#1661)

* feat: bill follow and unfollow functionality to testimony page

* ran prettier

* fix: remove unnecesary code

* fix: run linter

---------

Co-authored-by: Merritt Baggett <[email protected]>

* V2 style copy updates (#1680)

* undo main commit

* fix: v2 styple copy and updates

* feat: fixed hyperlink and summary

* feat: fixed hyperlink and summary

* fix: remove summary spacing

* Add HierarchicalMenu after InstantSearch initialize (#1684)

* Add HierarchicalMenu after InstantSearch initialize

* Run prettier

* removed obsolete spinner (#1686)

---------

Co-authored-by: huanfeng <[email protected]>
Co-authored-by: LauraUmana <[email protected]>
Co-authored-by: pranay8297 <[email protected]>
Co-authored-by: Nathan E. Sanders <[email protected]>
Co-authored-by: huanfeng <[email protected]>
Co-authored-by: kiminkim724 <[email protected]>
Co-authored-by: Kimin Kim <[email protected]>
Co-authored-by: mertbagt <[email protected]>
Co-authored-by: Merritt Baggett <[email protected]>
Co-authored-by: Aaron <[email protected]>
Co-authored-by: aerhartic <[email protected]>
Co-authored-by: ananyasinghz <[email protected]>
Co-authored-by: Huanfeng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants