Mastodon and bluesky to user profiles #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaerhart
requested review from
sashamaryl,
mertbagt,
nesanders,
mvictor55,
timblais,
alexjball,
Mephistic and
kiminkim724
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…b.com/aaerhart/maple into mastodon-and-bluesky-to-user-profiles
Mephistic
reviewed
Feb 5, 2025
Mephistic
reviewed
Feb 5, 2025
Mephistic
reviewed
Feb 5, 2025
| label={t("socialLinks.bluesky")} | ||
| defaultValue={social?.blueSky} | ||
| className="col-sm-12 col-md-6 mb-1" | ||
| iconSrc="./bluesky.svg" |
There was a problem hiding this comment.
I think the images issue here is related to the path:
- We currently have two images each for Facebook/Twitter/LinkedIn, one at
public/facebook.svgand another atpublic/images/facebook.svg. - The root of the image path for these components is
public/, so these components are trying to getpublic/bluesky.svgwhen we only addedpublic/images/bluesky.svgin the PR. - This will still work for Facebook/Twitter/etc. because they also have an image under just
public/, so it seems inconsistent - To make this load consistently, we should just move the
bluesky.svg/mastodon.svgout ofpublic/images/topublic/
components/db/profile/urlCleanup.ts
Outdated
| @@ -7,6 +7,15 @@ export function cleanSocialLinks(network: keyof SocialLinks, link: string) { | |||
| const index: number = path.indexOf(".com/") + 5 | |||
| path = path.substring(index) | |||
| } | |||
| if ( | |||
| network === "mastodon" && | |||
| path.substring(path.indexOf("@") + 1).charAt(0) === "@" | |||
There was a problem hiding this comment.
nit: This might be a bit easier to read as:
if (network === "mastodon" && path.startsWith("@")) {
path = path.substring(1)
}
mertbagt
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mastodon and Bluesky added as user profile features; users can add their urls for their accounts for those two platforms.
Known issues
Unknown if images display due to general image bug in the codebase. If they do, size might need to be adjusted.
Steps to test/reproduce
Check if the two platforms are mentioned in the edit profile