Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple connections #2505

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Conversation

worksofliam
Copy link
Contributor

@worksofliam worksofliam commented Feb 5, 2025

  • Adds the ability to have multiple connections with a single window
  • Supports the concept of an 'active connection'
  • For backwards compatability, getConnection will always return the first connection. Extensions will need to be updated to use getActiveConnection
  • Events fire with the active connection as a parameter
  • Generated Uris now require to use the authority property which maps to a connection id.

To do:

  • All Uris need to be updated to include the connection name (or host name) as part of the Uri since we can have multiple systems
  • Stop the ability to connect to the same system more than once in the UI (you can just keep clicking the Server node)
  • New event is needed to fire when the connection is switched
  • Add a mode to disable multi-connection mode in the extension, with the feature togglable for those that know what they are doing. We need time to let the extensions to catch up (The db2 extension will need some work to support the new APIs)

Copy link
Contributor

github-actions bot commented Feb 5, 2025

👋 A new build is available for this PR based on 7cebe01.

@worksofliam worksofliam changed the title Feature/multiple_connections Support multiple connections Feb 5, 2025
Signed-off-by: worksofliam <[email protected]>
@worksofliam worksofliam temporarily deployed to testing_environment February 5, 2025 19:49 — with GitHub Actions Inactive
Signed-off-by: worksofliam <[email protected]>
Signed-off-by: worksofliam <[email protected]>
@worksofliam worksofliam temporarily deployed to testing_environment February 7, 2025 04:08 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant