-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #328 : fix import new version software from HAL #334
Open
guillermau
wants to merge
1
commit into
main
Choose a base branch
from
Fix-import-HAL
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4694773
to
4d4e43d
Compare
JeromeBu
reviewed
Apr 4, 2025
@@ -27,7 +27,20 @@ export const importFromHALSource: (dbApi: DbApiV2) => (agentEmail: string) => Pr | |||
const index = dbSoftwaresNames.indexOf(software.title_s[0]); | |||
|
|||
if (index != -1) { | |||
return dbSoftwares[index].softwareId; | |||
console.log(dbSoftwares[index].externalId, " == ", software.docid); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tu veux garder ce log ?
Comment on lines
31
to
43
if (dbSoftwares[index].externalId === software.docid) { | ||
return dbSoftwares[index].softwareId; | ||
} else { | ||
// New HAL notice version, need to update | ||
let newSoft = await halRawSoftwareToSoftwareForm(software); | ||
await dbApi.software.update({ | ||
softwareSillId: dbSoftwares[index].softwareId, | ||
formData: newSoft, | ||
agentId: agentId | ||
}); | ||
|
||
return dbSoftwares[index].softwareId; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on peut alléger un peu (sans else car on return) et tu as un let
au lieu de const
Suggested change
if (dbSoftwares[index].externalId === software.docid) { | |
return dbSoftwares[index].softwareId; | |
} else { | |
// New HAL notice version, need to update | |
let newSoft = await halRawSoftwareToSoftwareForm(software); | |
await dbApi.software.update({ | |
softwareSillId: dbSoftwares[index].softwareId, | |
formData: newSoft, | |
agentId: agentId | |
}); | |
return dbSoftwares[index].softwareId; | |
} | |
if (dbSoftwares[index].externalId === software.docid) { | |
return dbSoftwares[index].softwareId; | |
} | |
// New HAL notice version, need to update | On garde ce commentaire ?? | |
const newSoft = await halRawSoftwareToSoftwareForm(software); | |
await dbApi.software.update({ | |
softwareSillId: dbSoftwares[index].softwareId, | |
formData: newSoft, | |
agentId: agentId | |
}); | |
return dbSoftwares[index].softwareId; | |
} |
4d4e43d
to
7afe81e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #328