Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devym-37
approved these changes
Dec 4, 2023
| //currentFolderId가 바뀔 때마다 새로 카드리스트 업데이트 | ||
| useEffect(() => { | ||
| handleLoadCardList(currentFolderId); | ||
| }, [currentFolderId]); |
There was a problem hiding this comment.
api 호출시에는 handle보단 onLoad / fetch라는 접두사가 api 호출 함수로 파악하기 쉬울 것 같습니다
| setSelectedLinkUrl(link?.url ?? ""); | ||
| setCurrentModal(MODALS_ID.addToFolder); | ||
| }} | ||
| /> |
There was a problem hiding this comment.
() => {} 함수보다는 어떤 동작을 하는 함수인지, 분리해서 작성해주시면, 좋을 것 같습니다
| description={selectedLinkUrl} | ||
| buttonText="삭제하기" | ||
| onClick={() => {}} | ||
| onCloseClick={closeModal} |
There was a problem hiding this comment.
onClick에 빈 함수가 들어가는 것 같습니다
| const handleBackgroundClick = useCallback(() => { | ||
| setIsPopoverOpen(false); | ||
| }, []); | ||
| const handleDeleteClick: MouseEventHandler<HTMLLIElement> = (event) => { |
There was a problem hiding this comment.
handleBackgroundClick 해당 함수 useCallback을 사용하신 이유가 있으실까요 ?
| const body = await response.json(); | ||
| return body; | ||
| } | ||
|
|
There was a problem hiding this comment.
해당 함수들도 공통 함수로 만들어서 중복을 줄일 수 있을 것 같습니다!
| <> | ||
| <button className={cx(".styled_button")}>{children}</button> | ||
| </> | ||
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
주요 변경사항
스크린샷
멘토에게