Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InSeong-So
approved these changes
Dec 7, 2023
InSeong-So
reviewed
Dec 7, 2023
| @@ -0,0 +1,19 @@ | |||
| import { ReactNode, useEffect, useState } from "react"; | |||
There was a problem hiding this comment.
Next.js useLayoutEffect를 제어하는 방식이 있답니다!
요건 공유해드릴게요 🤗
Comment on lines
+2
to
+3
| import styles from "./ImageWrapper.module.scss"; | ||
| type ImageWrapperProps = { |
There was a problem hiding this comment.
import과 본문은 한 칸 띄우기...! 가독성이 좋아져요.
| className: string; | ||
| }; | ||
|
|
||
| export const ImageWrapper = ({ children, className }: ImageWrapperProps) => { |
There was a problem hiding this comment.
React Type과 DOM Element Type을 잘 섞을 수 있답니다!
Comment on lines
+53
to
+56
| const handleKebabClick: MouseEventHandler<HTMLButtonElement> = (event) => { | ||
| event.preventDefault(); | ||
| setIsPopoverOpen(() => (isPopoverOpen ? false : true)); | ||
| }; |
There was a problem hiding this comment.
Suggested change
| const handleKebabClick: MouseEventHandler<HTMLButtonElement> = (event) => { | |
| event.preventDefault(); | |
| setIsPopoverOpen(() => (isPopoverOpen ? false : true)); | |
| }; | |
| const handleKebabClick: MouseEventHandler<HTMLButtonElement> = (event) => { | |
| event.preventDefault(); | |
| setIsPopoverOpen(() => !isPopoverOpen); | |
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
‘/folder’ 페이지를 Next.js 프로젝트에 맞게 변경 및 이전 했나요?
‘/shared’ 페이지를 Next.js 프로젝트에 맞게 변경 및 이전 했나요?
다른 페이지로 이동이 필요한 곳에 next/link의 Link를 적용했나요?
[] Input 컴포넌트에 값이 없는 경우 회색의 placeholder값을 볼 수 있나요?
Input 컴포넌트에 focus in 하면 파랑색 테두리를 볼 수 있나요?
Input 컴포넌트에 눈 모양 아이콘을 누르면 비밀번호 가리기/보기 기능이 토글 되나요?
-[] Input 컴포넌트에 값이 에러케이스일 경우 빨강색 테두리와 에러 메세지를 볼 수 있나요?
-[] Input 컴포넌트에서 focus out 하면 실행할 함수를 설정할 수 있나요?
심화
주요 변경사항
스크린샷
멘토에게