Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub-actions [Fix] delete merged branch github action
…y-Mission into part3-손지은-week13
llucas93
reviewed
Dec 4, 2023
| @@ -0,0 +1,69 @@ | |||
| import { createContext, useEffect, useState } from "react"; | |||
There was a problem hiding this comment.
next에서는 폴더를 기준으로 라우팅이 동작됩니다.
pages/folder/index.tsx 처럼 구분해주시는게 좋아보여요 👍
Routing 참고링크
| import EyeOffIcon from "@/src/assets/img/eye-off.svg"; | ||
| import EyeOnIcon from "@/src/assets/img/eye-on.svg"; | ||
| import clsx from "clsx"; | ||
|
|
There was a problem hiding this comment.
네 input쪽은 지은님 말씀하신대로 분리가 필요해보입니다 👍
(의견 )(useInput으로 input 로직들만 훅으로 관리해도 좋을것같구요)
| const [emailErrorMessage, setEmailErrorMessage] = useState(""); | ||
| const [pwdErrorMessage, setPwdErrorMessage] = useState(""); | ||
| const [pwdType, setPwdType] = useState("password"); | ||
| const emailInput = useRef<any>(""); |
There was a problem hiding this comment.
타입 any로 선언하신 이유가 있을까요? (any는 지양합시다 👍 )
|
|
||
| const handleInputChange = ( | ||
| e: React.ChangeEvent<HTMLInputElement>, | ||
| inputRef: React.MutableRefObject<string> |
There was a problem hiding this comment.
inputRef는 따로 파라미터로 받는 이유가 있을까요?
There was a problem hiding this comment.
onChange가 emailInput에서 일어나면 emailInput의 value를, pwdInput에서 일어나면 pwdInput의 value를 바꿔주기 위해서입니다.
| } | ||
|
|
||
| export async function getFolder({ id }: { id: number }) { | ||
| const res = await fetch(`${API.baseURL}/users/${id}/folders`); |
There was a problem hiding this comment.
next자체 fetch를 제공해줍니다 추후 리팩토링이나 다음 과제 하실때 아래 링크 참고하시는걸 추천드려요 👍
nextjs Data Fetching
|
고생하셨습니다 지은님! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
주요 변경사항
스크린샷
배포주소 : https://jieun.vercel.app/signin
멘토에게