-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[김승석] Sprint4 #146
The head ref may contain hidden characters: "Basic-\uAE40\uC2B9\uC11D-sprint4"
[김승석] Sprint4 #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
height: 32px; | ||
margin-top: -32px; | ||
padding: 8px 16px 0px; | ||
color: #F74747; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 색상을 자주 사용하는 것 같은데,
CSS 색상 변수로 등록하면 좋을 것 같아요.
@@ -7,6 +7,7 @@ | |||
|
|||
<link rel="stylesheet" as="style" crossorigin href="https://cdn.jsdelivr.net/gh/orioncactus/[email protected]/dist/web/variable/pretendardvariable.min.css" /> | |||
<link rel="stylesheet" href="/css/style.css"> | |||
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/animate.css/4.1.1/animate.min.css"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
animate.css는 어떤 부분에 사용하기 위해 추가한 건가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아, animate.css 사용해보려다가 안했는데 지우겠습니다~
const targetId = e.target.getAttribute('id'); | ||
|
||
// 이메일 체크 | ||
if(targetId === 'panda_email'){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switch 써도 괜찮아 보여요.
|
||
// 이메일 체크 | ||
if(targetId === 'panda_email'){ | ||
if(e.target.value !== ''){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
early return 패턴으로 오류 조건을 처리해도 좋을 것 같아요.
요구사항
기본
로그인
회원가입
심화
멘토에게
https://kss-sprint-mission.netlify.app/
디자인에는 조건에 만족한 input에 효과(파란테두리)가 적용 되어있지만,
요구사항에는 없어서 고민하다가 일단 디자인대로 효과 적용했습니다.
미션5 부터는 변수명을 신경써서 작성하겠습니다.
셀프 코드 리뷰를 통해 질문 이어가겠습니다.