Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub-actions [Fix] delete merged branch github action
|
package-lock.json 위 파일들의 충돌이 자꾸 발생한다고 깃에서 경고 문구가 뜨는데 로컬파일에서는 따로 충돌이 보이지 않아 어떻게 해결해야될지 모르겠습니다 ㅠ |
devToram
approved these changes
Dec 1, 2024
| const [input, setInput] = useState(""); | ||
|
|
||
| const onPressEnter = (event) => { | ||
| if (event.nativeEvent.isComposing) return; |
|
|
||
| function ItemCard({ item, imgSizeClass }) { | ||
| const imageUrl = | ||
| item.images && item.images.length > 0 ? item.images[0] : defaultImage; |
There was a problem hiding this comment.
요런 문법도 써보면 재밌어요!
Suggested change
| item.images && item.images.length > 0 ? item.images[0] : defaultImage; | |
| item?.images?.[0] ?? defaultImage; |
Comment on lines
+9
to
+17
| const sortedItems = [...items].sort((a, b) => { | ||
| if (sortType === "newest") { | ||
| return new Date(b.createdAt) - new Date(a.createdAt); | ||
| } | ||
| if (sortType === "favorite") { | ||
| return b.favoriteCount - a.favoriteCount; | ||
| } | ||
| return 0; | ||
| }); |
There was a problem hiding this comment.
spread 연산자의 세심함...👍 early return 도 좋습니다!
| function AddItem() { | ||
| const [name, setName] = useState(""); | ||
| const [description, setDescription] = useState(""); | ||
| const [price, setPrice] = useState(""); |
Comment on lines
+13
to
+20
| try { | ||
| const data = await getItems(); | ||
| setItems(data); | ||
| setLoading(false); | ||
| } catch (err) { | ||
| setError(err.message); | ||
| setLoading(false); | ||
| } |
There was a problem hiding this comment.
setLoading 은 api 의 에러 여부와 관계없이 처리되는 값이라서 finally 로 받아주는 게 자연스러울 거 같아요!
Suggested change
| try { | |
| const data = await getItems(); | |
| setItems(data); | |
| setLoading(false); | |
| } catch (err) { | |
| setError(err.message); | |
| setLoading(false); | |
| } | |
| try { | |
| const data = await getItems(); | |
| setItems(data); | |
| } catch (err) { | |
| setError(err.message); | |
| } finally { | |
| setLoading(false); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
체크리스트 [기본]
상품 등록
심화
주요 변경사항
스크린샷
멘토에게