Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devToram
approved these changes
Dec 9, 2024
Comment on lines
+12
to
+16
| } else if (width < 1280) { | ||
| return 6; | ||
| } else { | ||
| return 10; | ||
| } |
There was a problem hiding this comment.
Suggested change
| } else if (width < 1280) { | |
| return 6; | |
| } else { | |
| return 10; | |
| } | |
| } | |
| if (width < 1280) { | |
| return 6; | |
| } | |
| return 10; | |
| } |
There was a problem hiding this comment.
여러 군데서 쓰이는 함수라서 util 화 시켜도 좋을 거 같아요~
Comment on lines
+25
to
+26
| fetchItemData(); | ||
| fetchCommentData(); |
There was a problem hiding this comment.
useEffect 내부에서만 사용하는 함수인 경우 useEffect 내부에서 선언하는 걸 추천드려요!
|
|
||
| function DetailPage() { | ||
| const { itemSlug } = useParams(); | ||
| const [item, setItem] = useState(null); |
There was a problem hiding this comment.
item 을 구조분해 할당해서 사용하는 것도 좋을 거 같아요!
| import { ReactComponent as RightArrow } from "../assets/arrow_right.svg"; | ||
|
|
||
| const PaginationBar = ({ totalPageNum, activePageNum, onPageChange }) => { | ||
| const maxVisiblePages = 5; |
Comment on lines
+9
to
+14
| if (totalPageNum <= maxVisiblePages) { | ||
| startPage = 1; | ||
| } else { | ||
| startPage = Math.max(activePageNum - Math.floor(maxVisiblePages / 2), 1); | ||
| startPage = Math.min(startPage, totalPageNum - maxVisiblePages + 1); | ||
| } |
There was a problem hiding this comment.
이 부분에서 startPage 값이 정해지기 때문에 let 대신 const 쓰도록 바꿀 수 있을 거 같아요!
| return ( | ||
| <div className={styles.tagsDisplaySection}> | ||
| {tags.map((tag, index) => ( | ||
| <div className={styles.tag} key={`tag-display-${index}`}> |
There was a problem hiding this comment.
단순히 index 를 key 로 주는 건 안주는 것과 동일해요! (실제로 key 안주면 react 내부에서 처리하는 방식)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
미완성 파일 제출합니다.
스크린샷
멘토에게