Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongqui
approved these changes
Jan 8, 2025
|
|
||
| .inner,.box_inner { margin:0 auto; min-width:325px; max-width:1120px; } | ||
|
|
||
| :root { |
|
|
||
| .font_1 { font-size:40px; } | ||
| .font_2 { font-size:24px; } | ||
| .font_3 { font-size:18px; } |
There was a problem hiding this comment.
공통으로 사용되는 스타일을 클래스로 잘 정의해주셨습니다~! 👍
| @@ -0,0 +1,10 @@ | |||
|
|
|||
|
|
|||
|
|
|||
| @@ -0,0 +1,110 @@ | |||
|
|
|||
| <html> | |||
There was a problem hiding this comment.
을 써주시면
SEO, 접근성에 도움이 됩니다! :)
|
|
||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | ||
| <meta name="robots" content="noindex"> | ||
| <meta name="Keywords" content="판다마켓,쇼핑몰" /> |
| <header> | ||
| <div class="inner"> | ||
| <a href="/" class="logo_top"> | ||
| <img src="/images/logo_01.png"> |
There was a problem hiding this comment.
img를 쓰실 때 alt를 넣어주시는 것이 접근성에 좋습니다!
| <div class="box"> | ||
| <img src="/images/Img_home_01.png" alt="Hot item"> | ||
| <div> | ||
| <h4 class="font_3">Hot item</h4> |
There was a problem hiding this comment.
h tag 는 계층 구조로 사용하시는 것이 접근성에 좋습니다! h1은 페이지에 하나가 되어야합니다 :)
https://developer.mozilla.org/ko/docs/Web/HTML/Element/Heading_Elements#사용_일람
| .btn:active { background-color: #1251AA; color:#fff; } | ||
| .btn.n_act { background-color: #9CA3AF; color:#fff; } | ||
|
|
||
| .btn._a { display:inline-block; padding:16px 124px; border-radius: 50px; } |
There was a problem hiding this comment.
._a 보다는 rounded 등 좀 더 유의미한 이름이면 더 좋을 거 같습니다 :)
| .section._4 .text_box { width:100%; padding:0 24px; text-align: center; top:10%; } | ||
| .section._4 .text_box { top:20%; } | ||
| } | ||
| @media (max-width: 780px) { |
| .section._4 .text_box { width:100%; padding:0 24px; text-align: center; top:10%; } | ||
| .section._4 .text_box { top:20%; } | ||
| } | ||
| @media (max-width: 780px) { |
There was a problem hiding this comment.
미션 1 내용은 아니지만, 모바일 화면에서 요소 간격이 멀어지는 현상이 있습니다~! 이후 다시 진행하실 때 참고 해주세요 ㅎㅎ
|
오 감사합니다!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
설정해 보세요.(설정값은 자유입니다)
주요 변경사항
스크린샷
멘토에게