Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[강영훈] Week 20 #1073

Open
wants to merge 19 commits into
base: part3-강영훈
Choose a base branch
from
Open

[강영훈] Week 20 #1073

wants to merge 19 commits into from

Conversation

harrykotter
Copy link
Collaborator

요구사항

기본

  • 변경된 api를 활용해 주세요.
  • api 요청에 TanStack React Query를 활용해 주세요.
  • Github에 위클리 미션 PR을 만들어 주세요.
  • React, Next.js를 사용해 진행합니다.

주요 변경사항

  • tanstack query 적용

스크린샷

Untitled3

멘토에게

  • 현재 요구사항대로 모든 api 요청에 react query를 사용하라 했는데, 로그인, 회원가입처럼 query로 캐싱한 데이터가 없어도 쓸 필요가 있나요? 굳이 싶었지만 일단 적용은 해뒀습니다!
  • 추후에 모달 기능 및 api 추가할 예정입니다
  • 셀프 코드 리뷰를 통해 질문 이어가겠습니다.

harrykotter added 19 commits May 8, 2024 20:05
@harrykotter
♻️ Refactor axios interceptor code
c73e262 
refactor separated axios instance and interceptor
@harrykotter
♻️ Refactor segments to optional catch-all segments
c0580ee 
refactor segments to optional catch-all segments for merging folder, shared page
@harrykotter
🐛 Fix router issue
424b033 
Fix No Router Instance issue & load 404 page when segments are wrong
@harrykotter
♻️ Separate linkRef hook
cedbbb1 
Separate linkRef hook from folder page
@harrykotter
⚰️ Remove unused codes
0668390 
remove unused imports, codes
@harrykotter
🐛 Fix localStorage unimport issue
b6540b2 
fix localStorage issue
@harrykotter
🐛 Fix button submit issue
03d09c5 
fix eyecon button type to button for preventing uneccessery submit
@harrykotter
🐛 Fix axios instance issue
5fafd9d 
fox axios token issue
@harrykotter
➕ Add react query library
eae3fa9 
Add react query library for server state management
@harrykotter
♻️ Separate api finctions
0f82aeb 
Separate api functions for refactor convenience
@harrykotter
⚰️ Remove uneccessery api codes
99154d5 
Remove uneccessery api codes from separating api codes
@harrykotter
♻️ Change api address as designated
f61121d 
Change api host url as designated address
@harrykotter
♻️ Refactor api codes by given url
f03398b 
Refactor aoi codes due to api changes
@harrykotter
♻️ Refactor shared page api codes
8912136 
Refactor shared page api codes due to api changes
@harrykotter
♻️ Refactor sign-in & sign-up page api codes
18e2f6b 
Refactor sign-in, sign-up page api codes due to api changes
@harrykotter
⚰️ Removed dead code
a7e6c13 
Remove dead code
@harrykotter
🎨 Apply react query to folder & shared page
99ebf85 
Apply react query to folder & shared page
@harrykotter
🎨 Apply react query in signin, signup proccess
fb98b75 
Apply react query in signin, signup proccess
@harrykotter
🧑‍💻 Zoom query tool font
9fecb25 
Zoom query tool font size for better view
@vercel Vercel
Copy link

vercel bot commented May 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
4-weekly-mission ❌ Failed (Inspect) May 12, 2024 8:25am
4-weekly-mission-ursd ❌ Failed (Inspect) May 12, 2024 8:25am

@harrykotter harrykotter requested a review from lang92 May 12, 2024 08:27
@harrykotter harrykotter self-assigned this May 12, 2024
@harrykotter harrykotter added the 매운맛🔥 뒤는 없습니다. 그냥 필터 없이 말해주세요. 책임은 제가 집니다. label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lang92 lang92 Awaiting requested review from lang92

Assignees

@harrykotter harrykotter

Labels
매운맛🔥 뒤는 없습니다. 그냥 필터 없이 말해주세요. 책임은 제가 집니다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@harrykotter