[김창민] week20 #1076
Open
[김창민] week20 #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
domuk-k
approved these changes
May 16, 2024
| }); | ||
| } | ||
|
|
||
| export function useGetUser() { |
There was a problem hiding this comment.
템플릿 코드에서 중요한차이가 userId를 인자로 받는지 여부군요.
use get user 기 때문에, 특정 user를 조회하는 기능을 가진 훅인데, userId를 받지 않는 다는 것만으로도 혼동을 줄만한 상황입니다. 템플릿코드를 참고해주세요. 아래라인에서 좀더 코멘트드릴게요
Comment on lines
+75
to
+85
| const data = responseData?.[0] && { | ||
| id: responseData?.[0].id, | ||
| name: responseData?.[0].name, | ||
| email: responseData?.[0].email, | ||
| imageSource: responseData?.[0].image_source, | ||
| }; | ||
| localStorage.setItem("userId", data.id); | ||
|
|
||
| return data; | ||
| }, | ||
| enabled: !!token, |
There was a problem hiding this comment.
기존 코드에서처럼, !!userId가 추가되어야 react-query로 안정적으로 마이그레이션했다고 할 수 있을거같아요. 지금은 동작이 달라질걸로 보입니다. userId 없이 유저목록을 조회하고 그 중에 언제나 첫번째 유저를 반환할거라서요
enabled: !!token && !!userId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
변경된 api를 활용해 주세요.
모달에 필요한 api 요청을 만들어 기능을 완성해 주세요.
api 요청에 TanStack React Query를 활용해 주세요.
Github에 위클리 미션 PR을 만들어 주세요.
React, Next.js를 사용해 진행합니다.
심화
주요 변경사항
스크린샷
멘토에게
커밋이 많지만 제일 마지막 커밋만 제가 작업한 파일입니다