-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[임채민] Week20 #1085
Open
Chaemin-153
wants to merge
46
commits into
codeit-bootcamp-frontend:part3-임채민
Choose a base branch
from
Chaemin-153:part4-임채민-week20
base: part3-임채민
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
The head ref may contain hidden characters: "part4-\uC784\uCC44\uBBFC-week20"
Open
[임채민] Week20 #1085
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
19de492
Initial commit from Create Next App
withyj-codeit c6d12fc
Ready to Developement
Chaemin-153 1168874
Refactor : Finished 7week
Chaemin-153 b5d7ca9
Refactor : 7week's code review
Chaemin-153 1e02132
Feat : Router 도입
Chaemin-153 d502f6e
Refactor : a -> Link 태그로 변경
Chaemin-153 3de4f6a
Feat : 페이지 title -> Helmet 사용
Chaemin-153 8a674b0
Refactor : Folder 페이지 추가
Chaemin-153 7d8c289
Refactor : 폴더 구조 변경
Chaemin-153 07d901e
Feat : 8주차 미완성
Chaemin-153 1209fa8
Refactor : 8주차 코드리뷰 적용
Chaemin-153 eb2531d
9주차 미완성
Chaemin-153 3904634
:truck: Rename: CSS 파일명 첫글자 대문자로 변경
Chaemin-153 95e5120
:recycle: Refactor: CardList 컴포넌트 모듈화 작업
Chaemin-153 16d4741
:recycle: Refactor: Profile 컴포넌트 모듈화 작업
Chaemin-153 9946f16
:recycle: Refactor: SearchBar 컴포넌트 모듈화 작업
Chaemin-153 2b92956
:recycle: Refactor: AddLinkBar 컴포넌트 모듈화 작업
Chaemin-153 3b84f2f
:recycle: Refactor: Folder 페이지 컴포넌트 모듈화 작업
Chaemin-153 7947994
:truck: Rename: 파일명 jsx로 수정
Chaemin-153 f97510f
:package: Chore: Sass 패키지 설치
Chaemin-153 cd36178
:recycle: Refactor: 프로젝트 전체 스타일 module Scss로 변경
Chaemin-153 ef363ea
:bug: Fix: FolderCards에서 전체 카테고리 렌더링 이슈 해결
Chaemin-153 6337c02
:recycle: Refactor: Shared 페이지 컴포넌트 모듈화
Chaemin-153 c404531
:lipstick: Style: SearchBar width 값 변경
Chaemin-153 55db12d
:lipstick: Style: star, kebab 디자인 수정
Chaemin-153 6307121
:sparkles: Feat: AddFolderModal 추가
Chaemin-153 851557f
:sparkles: Feat: DeleteLinkModal 추가
Chaemin-153 676eeb0
:sparkles: Feat: 케밥 클릭시 Select Menu 팝오버 추가
Chaemin-153 f7adc44
:sparkles: Feat: AddLinkModal 추가
Chaemin-153 4103f8a
:sparkles: Feat: EditFolderModal 추가
Chaemin-153 0325851
:sparkles: Feat: DeleteFolderModal 추가
Chaemin-153 b174882
:package: Chore: Typescript 패키지 설치
Chaemin-153 3022554
:package: Chore: TS 마이그레이션
Chaemin-153 04dddcd
:recycle: Refactor: 프로젝트 전체 TS 적용
Chaemin-153 23ffd01
Squashed commit of the following:
Chaemin-153 a86aad9
:sparkles: Feat: 검색 필터링 기능 추가
Chaemin-153 b1e1e6c
:recycle: Refactor: Next로 마이그레이션
Chaemin-153 5a24a3e
:lipstick: Style: 마이그레이션 후 Style 깨짐 수정
Chaemin-153 9cad33a
:sparkles: Feat: EmailInputForm 추가
Chaemin-153 c76237a
:sparkles: Feat: PasswordInput 토글 기능 추가
Chaemin-153 8fc7bf4
Refactor: App Router로 변경
Chaemin-153 b0570bd
Refactor: 폴더구조 변경(src 폴더 추가)
Chaemin-153 79a9ff6
Refactor: 라우팅 및 Layout 수정
Chaemin-153 fd2cc05
feat: 로그인 페이지 추가
Chaemin-153 7fa95a4
feat: 회원가입 페이지 추가
Chaemin-153 ad9a75b
feat: AccessToken 없을 시, 로그인 페이지로 이동
Chaemin-153 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"extends": "next/core-web-vitals" | ||
} |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files. | ||
|
||
# dependencies | ||
/node_modules | ||
/.pnp | ||
.pnp.js | ||
.yarn/install-state.gz | ||
|
||
# testing | ||
/coverage | ||
|
||
# next.js | ||
/.next/ | ||
/out/ | ||
|
||
# production | ||
/build | ||
|
||
# misc | ||
.DS_Store | ||
*.pem | ||
.env.local | ||
.env.development.local | ||
.env.test.local | ||
.env.production.local | ||
|
||
# debug | ||
npm-debug.log* | ||
yarn-debug.log* | ||
yarn-error.log* | ||
|
||
# local env files | ||
.env*.local | ||
|
||
# vercel | ||
.vercel | ||
|
||
# typescript | ||
*.tsbuildinfo | ||
next-env.d.ts |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
This is a [Next.js](https://nextjs.org/) project bootstrapped with [`create-next-app`](https://github.com/vercel/next.js/tree/canary/packages/create-next-app). | ||
|
||
## Getting Started | ||
|
||
First, run the development server: | ||
|
||
```bash | ||
npm run dev | ||
# or | ||
yarn dev | ||
# or | ||
pnpm dev | ||
# or | ||
bun dev | ||
``` | ||
|
||
Open [http://localhost:3000](http://localhost:3000) with your browser to see the result. | ||
|
||
You can start editing the page by modifying `pages/index.tsx`. The page auto-updates as you edit the file. | ||
|
||
[API routes](https://nextjs.org/docs/api-routes/introduction) can be accessed on [http://localhost:3000/api/hello](http://localhost:3000/api/hello). This endpoint can be edited in `pages/api/hello.ts`. | ||
|
||
The `pages/api` directory is mapped to `/api/*`. Files in this directory are treated as [API routes](https://nextjs.org/docs/api-routes/introduction) instead of React pages. | ||
|
||
This project uses [`next/font`](https://nextjs.org/docs/basic-features/font-optimization) to automatically optimize and load Inter, a custom Google Font. | ||
|
||
## Learn More | ||
|
||
To learn more about Next.js, take a look at the following resources: | ||
|
||
- [Next.js Documentation](https://nextjs.org/docs) - learn about Next.js features and API. | ||
- [Learn Next.js](https://nextjs.org/learn) - an interactive Next.js tutorial. | ||
|
||
You can check out [the Next.js GitHub repository](https://github.com/vercel/next.js/) - your feedback and contributions are welcome! | ||
|
||
## Deploy on Vercel | ||
|
||
The easiest way to deploy your Next.js app is to use the [Vercel Platform](https://vercel.com/new?utm_medium=default-template&filter=next.js&utm_source=create-next-app&utm_campaign=create-next-app-readme) from the creators of Next.js. | ||
|
||
Check out our [Next.js deployment documentation](https://nextjs.org/docs/deployment) for more details. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/** @type {import('next').NextConfig} */ | ||
const nextConfig = { | ||
reactStrictMode: true, | ||
images: { | ||
domains: [ | ||
'img1.daumcdn.net', | ||
'yt3.googleusercontent.com', | ||
'velog.velcdn.com', | ||
'avatars.githubusercontent.com', | ||
'codeit-images.codeit.com', | ||
'codeit-frontend.codeit.com', | ||
'reactjs.org', | ||
'assets.vercel.com', | ||
'storybook.js.org', | ||
'testing-library.com', | ||
'static.cdninstagram.com', | ||
's.pstatic.net', | ||
'tanstack.com', | ||
], | ||
remotePatterns: [ | ||
{ | ||
protocol: 'https', | ||
hostname: 'codeit-images.codeit.com', | ||
pathname: '/api/**', //**는 해당 경로 뒤에 모든 경로, | ||
}, | ||
], | ||
}, | ||
}; | ||
|
||
export default nextConfig; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아마, 앱라우터 정책 상 외부 이미지를 화이트리스트로 받는다는 점에서 이렇게 설정하신 것 같군요.
요구사항은 사용자가 이미지 URL을 넣도록 되어 있어서 '모든 URL'이 될 수 있다는 점과 NextJS 보안 정책에 의해 막히고 있는 듯 합니다.
현재 채민님께서 대부분의 도메인들을 허용해주고 있으나 근본적인 해결책은 아닌 것을 자각하고 계실거라 생각해요.
이럴 경우 모든 도메인을 허용
**
해주는 방법이 있으나 이는 NextJS 외부 이미지를 통한 보안을 해제하는 것과 다름 없습니다.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그럼 어떻게 할까?
제가 제안드리는 솔루션은 특정 컴포넌트에서만 모든 외부 이미지를 허용해주는게 어떨지 제안드립니다:
위처럼 설정해두면
Card
컴포넌트에서만 모든 외부 도메인이 허용될 수 있습니다. 😊