-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[신지원] Sprint1 #12
The head ref may contain hidden characters: "Basic-\uC2E0\uC9C0\uC6D0-sprint1"
[신지원] Sprint1 #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
처음 미션인데 잘 작성해주신 것 같습니다. 제가 리뷰에 중요 라고 남겨뒀던 부분을 특히 더 신경써서 봐주시면 좋을 것 같습니다. 고생 많으셨습니다! 👍
<body> | ||
<header> | ||
<a href="/"><img class="logo" src="images/logo.svg"></a> | ||
<a href="/login" class="login" type="button" value="로그인">로그인</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
button
요소를 직접적으로 사용하여
<a><button></button></a>
와 같이 사용하시는 게 더 좋습니다!
</head> | ||
<body> | ||
<header> | ||
<a href="/"><img class="logo" src="images/logo.svg"></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
img
태그와 같이 닫는 태그가 별도로 없는 태그는 끝 부분을 <img class="logo" src="images/logo.svg" />
와 같이 />
로 처리해주셔야 합니다.
</div> | ||
</nav> | ||
<main> | ||
<div class="mainfirst"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
정말 사소한 부분이지만, 클래스명에 두 단어가 있다면 -
로 구분하는 게 좋습니다. ex) main-first
일상의 모든 물건을<br> | ||
거래해 보세요 | ||
</h2> | ||
<a href="/items" class="view" type="button" value="구경하러가기">구경하러 가기</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도 <a><button></button></a>
이 되어야 합니다.
<nav> | ||
<div class="toppanda"> | ||
<h2> | ||
일상의 모든 물건을<br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
멘토링 시간에 말씀드린대로,
<p>12</p>
<p>34</p>
와 같은 방법을 사용해서 줄바꿈하시는 게 좋습니다.
} | ||
|
||
.section-description { | ||
position: absolute; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분이 absolute일 필요가 없습니다.
예를 들어, .mainfirst
요소를 가로로 두 개 나눠서(왼쪽, 오른쪽으로) 왼쪽에는 이미지, 오른쪽에는 텍스트를 작성하기만 하면 됩니다.
background-image: url("images/navi.png"); | ||
background-repeat: no-repeat; | ||
background-size: 996px 447px; | ||
background-position: 701px 93px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
잘 하셨네요. 👍
} | ||
|
||
footer { | ||
width: 1920px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도 고정값일 필요가 없습니다.
} | ||
|
||
.lastmain { | ||
width: 1920px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도 마찬가지로 고정값일 필요가 없습니다.
background-repeat: no-repeat; | ||
background-size: 996px 540px; | ||
background-position: 701px; | ||
top: 2298px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
중요
여기 포함 모든 파트에서, top
, left
등으로 여백을 조절하시면 안 됩니다.
예를 들어 아래처럼 단순히 여러가지 섹션을 두고,
<section></section>
<section></section>
<section></section>
각 섹션 안에 위 아래 좌 우 padding
을 이용해 여백을 조절해야 합니다.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게