Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[오성준] Sprint1 #24

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added faq.html
Empty file.
Binary file added images/Group 19-1.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

파일명에 띄어쓰기는 넣지 않는게 좋습니다 !

브라우저에서 불러올 때 url의 경우 띄어쓰기는 %20과 같이 인코딩 되므로 웹 접근성이 저하될 수 있습니다. 또한 서버와 클라이언트 간의 인코딩 설정이 다를 경우 문자가 깨질 수 있습니다. 😊

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Group 19-2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Group 19.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Group [email protected]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시.. 팬더친구 로고가 너무 많은 것 같은데 히스토리가 있으실까염..?

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Group [email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Group [email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Group [email protected]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐼

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Group [email protected]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐼

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Group [email protected]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐼

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Img_home_01.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Img_home_02.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Img_home_03.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Img_home_bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Img_home_top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Property 1=Typo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Property [email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Property [email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Property 1=Variant3.png
Binary file added images/Property [email protected]
Binary file added images/Property [email protected]
3 changes: 3 additions & 0 deletions images/btn_visibility_off_24px.svg
10 changes: 10 additions & 0 deletions images/btn_visibility_on_24px-1.svg
10 changes: 10 additions & 0 deletions images/btn_visibility_on_24px-2.svg
3 changes: 3 additions & 0 deletions images/btn_visibility_on_24px.svg
Binary file added images/ic_facebook.png
Binary file added images/ic_instagram.png
Binary file added images/ic_twitter.png
Binary file added images/ic_youtube.png
Binary file added images/logo.png
Binary file added images/[email protected]
Binary file added images/[email protected]
Binary file added images/판다 얼굴.png
Binary file added images/판다 얼굴@2x.png
Binary file added images/판다 얼굴@3x.png
96 changes: 96 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
<!DOCTYPE html>
<html lang="en">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lang="ko" 속성을 사용해보는건 어떨까요?

Suggested change
<html lang="en">
<html lang="ko">

lang 속성은 Search bot이 탐색할 때 해당 문서가 어떠한 언어로 작성되어있는지 파악할 때 사용될 수 있습니다.
따라서 적절한 lang을 설정하시는걸 권장드립니다. 😊

lang의 기본 값은 '알 수 없음'입니다. 따라서 적절한 값의 lang 속성을 꼭 꼭 ! 설정해주시는걸 권장합니다 !
lang에 대해서 자세히 보기

SEO 마케팅 관련 기사

tl;dr

lang 속성은 다음을 포함하여 다양한 목적으로 사용됩니다.

  • 검색 엔진은 lang 속성을 사용하여 올바른 언어로 웹 페이지를 색인화합니다. 이를 통해 특정 언어로 검색하는 사용자에게 더 관련성이 높은 결과를 반환할 수 있습니다.
  • 화면 판독기는 lang 속성을 사용하여 언어 프로필을 전환하여 올바른 악센트와 발음을 제공합니다. 이는 시각 장애가 있는 사용자가 선호하는 언어로 웹 콘텐츠에 액세스하는 데 도움이 됩니다.
  • lang 속성을 사용하여 번역해야 하는 텍스트를 식별할 수 있습니다. 이는 다국어 웹사이트를 만들거나 사용자 생성 콘텐츠를 번역하는 데 유용할 수 있습니다.

<html> 요소 자체를 포함하여 텍스트 콘텐츠를 포함하는 모든 HTML 요소에 lang 속성을 지정해야 한다는 점에 유의하는 것이 중요합니다. 이렇게 하면 전체 웹페이지의 언어가 올바르게 식별됩니다.
원문 보기

<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>판다마켓</title>
<link rel="stylesheet" type="text/css" href='https://cdn.jsdelivr.net/gh/orioncactus/pretendard/dist/web/static/pretendard.css'>
<link rel="stylesheet" href="style.css">
</head>
<body>
<header>
<div class="gnb">
<div class="gnb-logo">
<img src="images/판다 얼굴.png" alt="판다얼굴로고">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt는 사람이 읽기 편하게. 그리고 그림을 표현하도록 작성하시면 됩니다 😊

Suggested change
<img src="images/판다 얼굴.png" alt="판다얼굴로고">
<img src="images/판다 얼굴.png" alt="판다 얼굴 로고">

<a href="/"><img src="images/logo.png" alt="판다마켓로고"></a>
</div>
<a class="gnb-login" href="login.html">로그인</a>
</div>
<div class="section01 image-top">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class/id를 단순히 숫자를 열거하는 것보다 어떤 "목적"인지 작성하는게 어떨까요?

다음은 *BEM 컨벤션을 따른 목적을 내포한 네이밍 예시입니다:

Suggested change
<div class="section01 image-top">
<section class="landing-section__image--left">

만약, 1, 2와 같은 순서가 숫자로 들어가야 한다거나 디자인을 보았을 때 직관적으로 재사용 가능한 패턴들로 보이는데 각자 다른 고유한 스타일이 들어가야한다면, 스타일 구성이 잘못되었는지도 확인해보면 좋습니다.

BEM: CSS 클래스/아이디 네이밍 컨벤션 중 하나예요. 더 알아보기

<div class="visual-text">
<h1>일상의 모든 물건을<br> 거래해 보세요</h1>
<a href="items.html">구경하러 가기</a>
</div>
</div>
</header>

<main>
<div class="container">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.container 안에 .wrapper 가 있고 div 가 계속 중첩되어 있는 모습이 가독성이 좋지 않다고 생각합니다.
.conainer 태그 안에 요소를 배치한 의도가 있을거라 생각해, 모든 커밋에서 .container 검색해봤습니다. .container 에 어떠한 스타일링도 없더군요. 빼버리는게 더 나을거 같습니다.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 생각입니다 !wrapper라는 단어를 container로 변경하는 것도 고려해보세요 😊

<div class="wrapper">
<div class="section02 hot-item">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.section01 랑 .section02 가 다른 부모 요소와 계층 구조를 가지는데, 유사한 클래스명을 부여한게 독특합니다.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맞습니다 ! 해당 사항은 코드리뷰를 통해서 설명드릴게요 !

<div class="section02-content">
<img class="section02-img" src="images/Img_home_01.png" alt="인기상품 확인 이미지">
<div class="section02-text">
<span>Hot item</span>
<h1 class="section02-title">인기 상품을<br>
확인해 보세요</h1>
<p>가장 HOT한 중고거래 물품을<br>
판다 마케에서 확인해 보세요</p>
</div>
</div>
</div>

<div class="section02 search ">
<div class="section02-content section02-content--reverse">
<img class="section02-img" src="images/Img_home_02.png" alt="인기상품 확인 이미지">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt가 적절히 잘 들어갔군요 😊👍

<div class="section02-text">
<span>Search</span>
<h1 class="section02-title">구매를 원하는<br>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<h1> 태그는 문서에 하나만 넣는게 어떨까요?

페이지 당 하나의 <h1>만 사용하세요. 여러 개를 써도 오류는 나지 않겠지만, 단일 <h1>이 모범 사례로 꼽힙니다. 논리적으로 생각했을 때도, <h1>은 가장 중요한 제목이므로 전체 페이지의 목적을 설명해야 할 것입니다. 두 개의 제목을 가진 책이나, 여러 개의 이름을 가진 영화는 볼 수 없죠! 또한 스크린 리더 사용자와 SEO에도 더 적합합니다.

h1에 대해서: MDN

상품을 검색하세요</h1>
<p>구매하고 싶은 물품은 검색해서<br>
쉽게 찾아보세요</p>
</div>
</div>
</div>

<div class="section02 register">
<div class="section02-content">
<img class="section02-img" src="images/Img_home_03.png" alt="인기상품 확인 이미지">
<div class="section02-text">
<span>Register</span>
<h1 class="section02-title">판매를 원하는<br>
상품을 등록하세요</h1>
<p>어떤 물건이든 판매하고 싶은 상품을<br>
쉽게 등록하세요</p>
</div>
</div>
</div>
</div>

<div class="section01 image-bottom">
<div class="visual-text">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

위의 클래스명의 경우 "section02-요소명" 처럼, 블록-요소 느낌으로 네이밍했다는 인상을 받았습니다. 그래서 visual-text 라는 클래스명이 기존 흐름에 비해 특이하다는 생각해봤습니다.

<h1>믿을 수 있는<br>
판다마켓 중고거래</h1>
</div>
</div>

</div>
</main>

<footer>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳굳 ! 적절한 시맨틱 태그입니다 👍

<div class="footer-content">
<span>@codeit - 2024</span>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

span 요소를 자주 쓰시네요. 부모인 div.footer-content 가 플렉스 박스여서
인라인이든 블록이든 flex-flow 따르게 되는데,
div 요소와 span 요소를 번갈아 쓰신 점 궁금합니다.

<div class="privacy-faq">
<a href="privacy.html"><span>Privacy Policy</span></a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a 태그 안에 바로 컨텐츠를 넣는 것이 아닌,
span 태그로 한번 더 감싼 의도가 궁금합니다.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<span>는 불필요한 태그로 보입니다:

Suggested change
<a href="privacy.html"><span>Privacy Policy</span></a>
<a href="privacy.html">Privacy Policy</a>

<a href="faq.html"><span>FAQ</span></a>
</div>
<div class="footer-icons">
<a href="https://www.facebook.com" target="_blank"><img src="images/ic_facebook.png" alt="페이스북 로고"></a>
<a href="https://www.twitter.com" target="_blank"><img src="images/ic_twitter.png" alt="트위터 로고"></a>
<a href="https://www.youtube.com" target="_blank"><img src="images/ic_youtube.png" alt="유튜브 로고"></a>
<a href="https://www.instagram.com" target="_blank"><img src="images/ic_instagram.png" alt="인스타그램 로고"></a>
</div>
</div>
</footer>
</body>
</html>
Empty file added items.html
Empty file.
Empty file added login.html
Empty file.
Empty file added privacy.html
Empty file.
191 changes: 191 additions & 0 deletions style.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,191 @@
:root {
--header-btn-bgcolor : #3692ff;
--header-btn-bgcolor--hover :#1251AA;
--section01-bg-color : #cfe5ff;
--section01-h1-color: #374151;
--section02-span-color :#3692ff;
--section02-p-color : #374151;
--section02-title-color : #374151;
--footer-bg-color : #111827;
--footer-text01 : #9CA3AF;
--footer-text02 : #E5E7EB;
--white : #ffffff;
}

* {
box-sizing:border-box;
margin: 0;
}
Comment on lines +1 to +18
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

해당 클래스는 global.css 혹은 color.css라는 파일에서 따로 관리하셔도 될 것 같아요 😊


body {
font-family: 'Pretendard', sans-serif;
}

.gnb {
margin:0px 200px;
}

.gnb,
.gnb-logo {
display: flex;
align-items: center;
}

.gnb {
justify-content: space-between;
height: 70px;
}

.gnb-login {
text-decoration: none;
color:var(--white);
background-color: var(--header-btn-bgcolor);
border-radius: 8px;
padding:12px 20px;
font-weight: 600;
flex-shrink: 0;
}

.gnb-login:hover {
background-color: var(--header-btn-bgcolor--hover)
}

.gnb-logo img {
margin-right: 10px;
}

.section01 {
height: 540px;
background-color: var(--section01-bg-color);
background-repeat: no-repeat;
background-size:55%;
background-position: right 20% bottom;
display: flex;
justify-content:left;
align-items: center;
}

.image-top {
background-image: url("images/img_home_top.png");
}

.image-bottom {
background-image: url("images/img_home_bottom.png");
}

.visual-text {
width: 100%;
max-width: 1200px;
margin: 0 auto;
}

.visual-text h1 {
font-size: 40px;
line-height: 56px;
margin-bottom: 32px;
font-weight: 700;
color:var(--section01-h1-color);
}

.visual-text a {
text-decoration: none;
color:var(--white);
background-color: var(--header-btn-bgcolor);
border-radius: 9999px;
padding:16px 124px;
display: inline-block;
font-size: 20px;
line-height: 24px;
font-weight: 600;
}

.visual-text a:hover {
background-color: var(--header-btn-bgcolor--hover)
}

.wrapper {
width: 100%;
max-width: 1200px;
margin:0 auto;
}

.section02 {
padding:100px 0px;
}

.section02-content--reverse {
justify-content: end;
flex-direction: row-reverse;
text-align: end;
}

.section02-content {
display: flex;
align-items: center;
gap:40px;
}

.section02-img {
width: 50%;
height: 50%;
}

.section02-text span {
font-size: 18px;
font-weight: 700;
line-height: 25.2px;
color: var(--section02-span-color)
}

.section02-title {
font-size: 40px;
margin:12px 0px 24px;
line-height: 56px;
font-weight: 700;
Comment on lines +141 to +144

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

font 속성의 경우 아래 mdn 참고하셔서, 한 줄 안에 표현할 수 있습니다.
위 코드의 경우
font: 700 40px / 56px 로 표현할 수 있습니다.

https://developer.mozilla.org/en-US/docs/Web/CSS/font#formal_syntax

color:var(--section02-title-color)
}

.section02-text p {
font-size: 24px;
font-weight: 500;
line-height: 28.8px;
color:var(--section02-p-color)
}

.search {
justify-content: end;
}

footer {
height: 160px;
background-color: var(--footer-bg-color);
color:var(--white);
padding:32px 200px;
}

.footer-content {
display: flex;
justify-content: space-between;
font-size: 16px;
font-weight: 400;
line-height: 19.09px;
}

.footer-content > span {
color:var(--footer-text01);
margin-right: 30px;
}

.privacy-faq a {
color: var(--footer-text02);
text-decoration:none;
margin-right: 30px;
}

.footer-icons {
flex-shrink: 0;
}

.footer-icons a {
margin-right: 13px;
}
Loading