-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[이태진] Sprint 1 #26
The head ref may contain hidden characters: "Basic-\uC774\uD0DC\uC9C4-sprint1"
[이태진] Sprint 1 #26
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,110 @@ | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
<head> | ||
<meta charset="UTF-8"> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
<title>판다마켓</title> | ||
<link rel="stylesheet" href="style.css"> | ||
</head> | ||
<body> | ||
<header> | ||
<section class="header-top-line"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
<div class="logo-set"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
<img src="image/panda_face.png" alt="판다 얼굴"> | ||
<a href="/"><img src="image/panda_market_logo.png" alt="판다마켓 로고"></a> | ||
</div> | ||
<span class="empty-center"></span> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 별도의 빈공간을 위한 요소를 추가하기 보다는 css 속성을 이용해 로고와 로그인 버튼의 배치를 조정해주시면 더 좋을 것 같습니다. |
||
<a href="/login" class="btn-login element-click">로그인</a> | ||
</section> | ||
<section class="header-main"> | ||
<div class="header-main-phrase"> | ||
<h1> | ||
일상의 모든 물건을<br> | ||
거래해 보세요 | ||
</h1> | ||
<a href="/items" class="btn-go-looking element-click">구경하러 가기</a> | ||
</div> | ||
<img src="image/header_picture.png" alt="상단 그림"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 대체 텍스트는 웹 접근성을 위해 해당 그림이 나타내는 내용을 정확하게 적어주는 것이 좋습니다. |
||
</section> | ||
</header> | ||
<main> | ||
<section class="card hot-item align-left"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
<img src="image/hot_item_picture.png" alt="인기 상품 그림"> | ||
<div class="card-info"> | ||
<div class="card-title">Hot item</div> | ||
<h1> | ||
인기 상품을<br> | ||
확인해 보세요 | ||
</h1> | ||
<p class="card-description"> | ||
가장 HOT한 중고거래 물품을<br> | ||
판다 마켓에서 확인해 보세요 | ||
</p> | ||
</div> | ||
</section> | ||
Comment on lines
+31
to
+44
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 반복되는 부분을 |
||
<section class="card search align-right"> | ||
<div class="card-info"> | ||
<div class="card-title">Search</div> | ||
<h1> | ||
구매를 원하는<br> | ||
상품을 검색하세요 | ||
</h1> | ||
<p class="card-description"> | ||
구매하고 싶은 물품은 검색해서<br> | ||
쉽게 찾아보세요 | ||
</p> | ||
</div> | ||
<img src="image/search_picture.png" alt="검색 그림"> | ||
</section> | ||
<section class="card register align-left"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
<img src="image/register_picture.png" alt="등록 그림"> | ||
<div class="card-info"> | ||
<div class="card-title">Register</div> | ||
<h1> | ||
판매를 원하는<br> | ||
상품을 등록하세요 | ||
</h1> | ||
<p class="card-description"> | ||
어떤 물건이든 판매하고 싶은 상품을<br> | ||
쉽게 등록하세요 | ||
</p> | ||
</div> | ||
</section> | ||
</main> | ||
<footer> | ||
<section class="footer-main"> | ||
<h1> | ||
믿을 수 있는<br> | ||
판다마켓 중고거래 | ||
</h1> | ||
<img src="image/footer_picture.png" alt="하단 그림"> | ||
</section> | ||
Comment on lines
+76
to
+82
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이 부분은 |
||
<section class="footer-bottom-line"> | ||
<div class="footer-line-left"> | ||
@codeit - 2024 | ||
</div> | ||
Comment on lines
+84
to
+86
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 변경에 유연한 코드 작성을 위해 위치 기반의 네이밍 보다는 |
||
<div class="footer-line-center"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 마찬가지로 위치 대신 |
||
<a href="/privacy">Privacy Policy</a> | ||
<a href="/faq">FAQ</a> | ||
</div> | ||
<div class="footer-line-right"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. SNS가 포함 된 이름으로 네이밍 해주시면 더 좋을 것 같습니다! |
||
<a href="https://www.facebook.com" target="_blank"> | ||
<img src="image/ic_facebook.png" alt="페이스북 아이콘"> | ||
</a> | ||
<a href="https://twitter.com" target="_blank"> | ||
<img src="image/ic_twitter.png" alt="트위터 아이콘"> | ||
</a> | ||
<a href="https://www.youtube.com" target="_blank"> | ||
<img src="image/ic_youtube.png" alt="유튜브 아이콘"> | ||
</a> | ||
<a href="https://www.instagram.com" target="_blank"> | ||
<img src="image/ic_instagram.png" alt="인스타 아이콘"> | ||
</a> | ||
</div> | ||
</section> | ||
</footer> | ||
|
||
|
||
</body> | ||
</html> |
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,197 @@ | ||||||||||||
* { | ||||||||||||
box-sizing: border-box; | ||||||||||||
} | ||||||||||||
|
||||||||||||
:root { | ||||||||||||
--element-gray-color: #374151; | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. --element-gray-color, --emelent-gray-color 두 가지가 서로 다른 회색을 표현하는 것이라면 light-gray 등의 표현을 통해 구분을 해주시는 게 좋을 것 같습니다. 🤗 |
||||||||||||
--element-sky-color: #3692FF; | ||||||||||||
--btn-hover-color: #1967D6; | ||||||||||||
--btn-active-color: #1251AA; | ||||||||||||
--btn-visited-color: #9CA3AF; | ||||||||||||
--white-color: #FFFFFF; | ||||||||||||
--bg-sky-color: #CFE5FF; | ||||||||||||
--emelent-gray-color: #9CA3AF; | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. --emelent 부분이 오타인 것 같습니다. |
||||||||||||
--bg-navy-color: #111827; | ||||||||||||
} | ||||||||||||
|
||||||||||||
body { | ||||||||||||
margin: 0; | ||||||||||||
color: var(--element-gray-color); | ||||||||||||
} | ||||||||||||
h1 { | ||||||||||||
font-size: 3vw; | ||||||||||||
} | ||||||||||||
.element-click { | ||||||||||||
cursor: pointer; | ||||||||||||
} | ||||||||||||
|
||||||||||||
.element-click:hover{ | ||||||||||||
background-color: var(--btn-hover-color); | ||||||||||||
} | ||||||||||||
|
||||||||||||
.element-click:active{ | ||||||||||||
background-color: var(--btn-active-color); | ||||||||||||
} | ||||||||||||
|
||||||||||||
.element-click:visited{ | ||||||||||||
background-color: var(--btn-visited-color); | ||||||||||||
} | ||||||||||||
|
||||||||||||
.btn-login { | ||||||||||||
background-color: var(--element-sky-color); | ||||||||||||
color: var(--white-color); | ||||||||||||
text-decoration: none; | ||||||||||||
border-radius: 5px; | ||||||||||||
width: 128px; | ||||||||||||
height: 48px; | ||||||||||||
display: flex; | ||||||||||||
justify-content: center; | ||||||||||||
align-items: center; | ||||||||||||
flex-grow: 0; | ||||||||||||
flex-shrink: 0; | ||||||||||||
} | ||||||||||||
|
||||||||||||
.btn-go-looking { | ||||||||||||
background-color: var(--element-sky-color); | ||||||||||||
color: var(--white-color); | ||||||||||||
text-decoration: none; | ||||||||||||
border-radius: 99999px; | ||||||||||||
width: 100%; | ||||||||||||
height: 56px; | ||||||||||||
display: flex; | ||||||||||||
justify-content: center; | ||||||||||||
align-items: center; | ||||||||||||
} | ||||||||||||
|
||||||||||||
.empty-center{ | ||||||||||||
width: 1200px; | ||||||||||||
} | ||||||||||||
|
||||||||||||
.logo-set { | ||||||||||||
display: flex; | ||||||||||||
justify-content: center; | ||||||||||||
align-items: center; | ||||||||||||
gap: 21px; | ||||||||||||
} | ||||||||||||
|
||||||||||||
.header-top-line { | ||||||||||||
display: flex; | ||||||||||||
justify-content: center; | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||
align-items: center; | ||||||||||||
margin-top: 10px; | ||||||||||||
margin-left: 200px; | ||||||||||||
margin-right: 200px; | ||||||||||||
margin-bottom: 10px; | ||||||||||||
Comment on lines
+81
to
+84
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
필수적인 부분은 아니지만 단축해서 작성해주시는 방식을 추천드립니다. |
||||||||||||
gap: 10px; | ||||||||||||
} | ||||||||||||
|
||||||||||||
.header-main { | ||||||||||||
background-color: var(--bg-sky-color); | ||||||||||||
display: flex; | ||||||||||||
justify-content: center; | ||||||||||||
align-items: center; | ||||||||||||
} | ||||||||||||
|
||||||||||||
.header-main img { | ||||||||||||
padding-top: 7%; | ||||||||||||
} | ||||||||||||
|
||||||||||||
.header-main-phrase { | ||||||||||||
display: flex; | ||||||||||||
flex-direction: column; | ||||||||||||
justify-content: center; | ||||||||||||
align-items: center; | ||||||||||||
} | ||||||||||||
|
||||||||||||
.header-main img { | ||||||||||||
width: 50%; | ||||||||||||
} | ||||||||||||
|
||||||||||||
main { | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||||||||||||
display: block; | ||||||||||||
max-width: 1200px; | ||||||||||||
margin: 0 auto; | ||||||||||||
} | ||||||||||||
|
||||||||||||
.card { | ||||||||||||
display: flex; | ||||||||||||
gap: 7vw; | ||||||||||||
padding-top: 10vw; | ||||||||||||
padding-bottom: 10vw; | ||||||||||||
} | ||||||||||||
|
||||||||||||
.card img { | ||||||||||||
width: 40vw; | ||||||||||||
object-fit: contain; | ||||||||||||
} | ||||||||||||
|
||||||||||||
|
||||||||||||
.align-right { | ||||||||||||
justify-content: end; | ||||||||||||
} | ||||||||||||
|
||||||||||||
|
||||||||||||
|
||||||||||||
.card-info { | ||||||||||||
display: flex; | ||||||||||||
flex-direction: column; | ||||||||||||
justify-content: center; | ||||||||||||
} | ||||||||||||
|
||||||||||||
.align-right .card-info { | ||||||||||||
align-items: end; | ||||||||||||
text-align: right; | ||||||||||||
} | ||||||||||||
|
||||||||||||
.card-title { | ||||||||||||
font-weight: 800; | ||||||||||||
color: var(--element-sky-color); | ||||||||||||
} | ||||||||||||
|
||||||||||||
.card-description { | ||||||||||||
font-size: 2vw; | ||||||||||||
} | ||||||||||||
|
||||||||||||
.card-right * { | ||||||||||||
margin-block-start: 0.3em; | ||||||||||||
margin-block-end: 0.3em; | ||||||||||||
} | ||||||||||||
|
||||||||||||
.footer-main { | ||||||||||||
margin-top: 100px; | ||||||||||||
} | ||||||||||||
|
||||||||||||
.footer-main { | ||||||||||||
background-color: var(--bg-sky-color); | ||||||||||||
display: flex; | ||||||||||||
justify-content: center; | ||||||||||||
align-items: center; | ||||||||||||
} | ||||||||||||
|
||||||||||||
.footer-main img { | ||||||||||||
padding-top: 7%; | ||||||||||||
width: 50% | ||||||||||||
} | ||||||||||||
|
||||||||||||
.footer-bottom-line { | ||||||||||||
background-color: var(--bg-navy-color); | ||||||||||||
color: var(--emelent-gray-color); | ||||||||||||
display: flex; | ||||||||||||
justify-content: space-around; | ||||||||||||
gap: 30px; | ||||||||||||
/* padding: 30px 200px 100px; */ | ||||||||||||
padding-top: 30px; | ||||||||||||
padding-bottom: 100px; | ||||||||||||
|
||||||||||||
|
||||||||||||
} | ||||||||||||
|
||||||||||||
.footer-bottom-line a { | ||||||||||||
text-decoration: none; | ||||||||||||
color: var(--white-color); | ||||||||||||
} | ||||||||||||
|
||||||||||||
.footer-line-center { | ||||||||||||
display: flex; | ||||||||||||
gap: 2vw; | ||||||||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
프로젝트에 사용되는 이미지들을 폴더에 잘 정리해주셨습니다 👍
다만, 폴더의 이름은
images
처럼 복수형을 써주시는게 더 좋을 것 같습니다.