Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[이태진] Sprint 1 #26

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added sprint_mission1/image/footer_picture.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

프로젝트에 사용되는 이미지들을 폴더에 잘 정리해주셨습니다 👍
다만, 폴더의 이름은 images처럼 복수형을 써주시는게 더 좋을 것 같습니다.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added sprint_mission1/image/header_picture.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added sprint_mission1/image/hot_item_picture.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added sprint_mission1/image/ic_facebook.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added sprint_mission1/image/ic_instagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added sprint_mission1/image/ic_twitter.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added sprint_mission1/image/ic_youtube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added sprint_mission1/image/panda_face.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added sprint_mission1/image/panda_market_logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added sprint_mission1/image/register_picture.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added sprint_mission1/image/search_picture.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
110 changes: 110 additions & 0 deletions sprint_mission1/index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,110 @@
<!DOCTYPE html>
<html lang="en">
Copy link
Collaborator

@dev-kjy dev-kjy Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 팀원 분들에게도 비슷한 피드백을 드렸는데요!
사이트의 내용이 한국어로 이루어져 있으므로 언어 설정을 ko로 하는 것을 추천드립니다.
접근성, SEO, 번역 동작 등에 영향을 미칠 수 있어서요.
더 자세한 내용은 아래 링크를 참고해주세요. 🤗
참고링크1
참고링크2

<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>판다마켓</title>
<link rel="stylesheet" href="style.css">
</head>
<body>
<header>
<section class="header-top-line">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 이라는 표현은 보는 사람에게는 가느다란 실선을 연상케 하는 것 같습니다. GNB(Global Navigation Bar)가 적절한 명칭으로 보이네요. 🤗

<div class="logo-set">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logo-set이라는 표현을 보면 좀 더 많은 로고들의 리스트가 떠오르는 것 같습니다.
정확한 용어의 경우 아래 링크에 잘 정리되어 있는데 자주 사용하는 용어는 아닌지라 home-button 정도로 지칭하면 자연스러울 듯 하네요 🤗

CI, Symbol, Logo Type에 대한 설명 링크

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아니면 이미지를 다운로드 하실 때 두 개의 영역을 합쳐 다운로드 하시는 것도 좋을 것 같습니다.
image

<img src="image/panda_face.png" alt="판다 얼굴">
<a href="/"><img src="image/panda_market_logo.png" alt="판다마켓 로고"></a>
</div>
<span class="empty-center"></span>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

별도의 빈공간을 위한 요소를 추가하기 보다는 css 속성을 이용해 로고와 로그인 버튼의 배치를 조정해주시면 더 좋을 것 같습니다.
(해당 코드는 css 파일쪽에 코멘트 달아두었습니다.)

<a href="/login" class="btn-login element-click">로그인</a>
</section>
<section class="header-main">
<div class="header-main-phrase">
<h1>
일상의 모든 물건을<br>
거래해 보세요
</h1>
<a href="/items" class="btn-go-looking element-click">구경하러 가기</a>
</div>
<img src="image/header_picture.png" alt="상단 그림">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대체 텍스트는 웹 접근성을 위해 해당 그림이 나타내는 내용을 정확하게 적어주는 것이 좋습니다.
스크린리더를 이용하는 유저를 대상으로 작성한다고 생각하시고 작성해주시면 좋을 것 같습니다. 🤗

</section>
</header>
<main>
<section class="card hot-item align-left">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hot-item은 제외해주셔도 될 것 같습니다. (현재의 구조가아닌 다른 구조일 때 사용된 클래스명으로 보이네요)

<img src="image/hot_item_picture.png" alt="인기 상품 그림">
<div class="card-info">
<div class="card-title">Hot item</div>
<h1>
인기 상품을<br>
확인해 보세요
</h1>
<p class="card-description">
가장 HOT한 중고거래 물품을<br>
판다 마켓에서 확인해 보세요
</p>
</div>
</section>
Comment on lines +31 to +44
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반복되는 부분을 card로 정의하고 자식 요소로 info 그 하위에 title, description으로 구조화 해주신 부분은 너무 좋습니다. 보는 사람도 쉽게 이해할 수 있고, 향후 유지보수에도 좋은 구조입니다. 👍👍👍

<section class="card search align-right">
<div class="card-info">
<div class="card-title">Search</div>
<h1>
구매를 원하는<br>
상품을 검색하세요
</h1>
<p class="card-description">
구매하고 싶은 물품은 검색해서<br>
쉽게 찾아보세요
</p>
</div>
<img src="image/search_picture.png" alt="검색 그림">
</section>
<section class="card register align-left">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

align-left는 해당 card 컴포넌트의 특징을 잘 드러내고 있어 좋습니다!
다만, 두 가지의 의미로 해석될 수 있으므로 text-align-left처럼 작성해주시는 것이 이해에 더 도움이 될 것 같아요.


<img src="image/register_picture.png" alt="등록 그림">
<div class="card-info">
<div class="card-title">Register</div>
<h1>
판매를 원하는<br>
상품을 등록하세요
</h1>
<p class="card-description">
어떤 물건이든 판매하고 싶은 상품을<br>
쉽게 등록하세요
</p>
</div>
</section>
</main>
<footer>
<section class="footer-main">
<h1>
믿을 수 있는<br>
판다마켓 중고거래
</h1>
<img src="image/footer_picture.png" alt="하단 그림">
</section>
Comment on lines +76 to +82
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 footer에 속하기 보다는 별도의 card 또는 배너 영역으로 보여집니다. 왜냐하면 사이트 전반적으로 보여지는 부분이 아니라 주로 랜딩페이지 하단에 속하는 내용이기 때문입니다. 위치를 옮겨주시면 좋을 것 같습니다.

<section class="footer-bottom-line">
<div class="footer-line-left">
@codeit - 2024
</div>
Comment on lines +84 to +86
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변경에 유연한 코드 작성을 위해 위치 기반의 네이밍 보다는 copyright처럼 해당 영역의 내용을 이름에 표현해 주시면 좋을 것 같습니다. 😃

<div class="footer-line-center">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마찬가지로 위치 대신 information 정도의 섹션으로 네이밍 해주시면 좋을 것 같아요!

<a href="/privacy">Privacy Policy</a>
<a href="/faq">FAQ</a>
</div>
<div class="footer-line-right">
Copy link
Collaborator

@dev-kjy dev-kjy Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SNS가 포함 된 이름으로 네이밍 해주시면 더 좋을 것 같습니다!

<a href="https://www.facebook.com" target="_blank">
<img src="image/ic_facebook.png" alt="페이스북 아이콘">
</a>
<a href="https://twitter.com" target="_blank">
<img src="image/ic_twitter.png" alt="트위터 아이콘">
</a>
<a href="https://www.youtube.com" target="_blank">
<img src="image/ic_youtube.png" alt="유튜브 아이콘">
</a>
<a href="https://www.instagram.com" target="_blank">
<img src="image/ic_instagram.png" alt="인스타 아이콘">
</a>
</div>
</section>
</footer>


</body>
</html>
197 changes: 197 additions & 0 deletions sprint_mission1/style.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,197 @@
* {
box-sizing: border-box;
}

:root {
--element-gray-color: #374151;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--element-gray-color, --emelent-gray-color 두 가지가 서로 다른 회색을 표현하는 것이라면 light-gray 등의 표현을 통해 구분을 해주시는 게 좋을 것 같습니다. 🤗

--element-sky-color: #3692FF;
--btn-hover-color: #1967D6;
--btn-active-color: #1251AA;
--btn-visited-color: #9CA3AF;
--white-color: #FFFFFF;
--bg-sky-color: #CFE5FF;
--emelent-gray-color: #9CA3AF;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--emelent 부분이 오타인 것 같습니다.

--bg-navy-color: #111827;
}

body {
margin: 0;
color: var(--element-gray-color);
}
h1 {
font-size: 3vw;
}
.element-click {
cursor: pointer;
}

.element-click:hover{
background-color: var(--btn-hover-color);
}

.element-click:active{
background-color: var(--btn-active-color);
}

.element-click:visited{
background-color: var(--btn-visited-color);
}

.btn-login {
background-color: var(--element-sky-color);
color: var(--white-color);
text-decoration: none;
border-radius: 5px;
width: 128px;
height: 48px;
display: flex;
justify-content: center;
align-items: center;
flex-grow: 0;
flex-shrink: 0;
}

.btn-go-looking {
background-color: var(--element-sky-color);
color: var(--white-color);
text-decoration: none;
border-radius: 99999px;
width: 100%;
height: 56px;
display: flex;
justify-content: center;
align-items: center;
}

.empty-center{
width: 1200px;
}

.logo-set {
display: flex;
justify-content: center;
align-items: center;
gap: 21px;
}

.header-top-line {
display: flex;
justify-content: center;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
justify-content: center;
justify-content: space-between;

span 태그를 이용해 빈공간을 만들기 보다는 css 속성을 이용해 배치를 해주시면 더 좋을 것 같습니다. 🤗

align-items: center;
margin-top: 10px;
margin-left: 200px;
margin-right: 200px;
margin-bottom: 10px;
Comment on lines +81 to +84
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
margin-top: 10px;
margin-left: 200px;
margin-right: 200px;
margin-bottom: 10px;
margin: 10px 200px;

필수적인 부분은 아니지만 단축해서 작성해주시는 방식을 추천드립니다.

gap: 10px;
}

.header-main {
background-color: var(--bg-sky-color);
display: flex;
justify-content: center;
align-items: center;
}

.header-main img {
padding-top: 7%;
}

.header-main-phrase {
display: flex;
flex-direction: column;
justify-content: center;
align-items: center;
}

.header-main img {
width: 50%;
}

main {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main 태그에 대한 선택자는 일반 클래스에 대한 선택자들과 같이 있는 것이 아니라 style.css 파일 최상단에 body, h1과 함께 위치하면 좋을 것 같습니다. 😃

display: block;
max-width: 1200px;
margin: 0 auto;
}

.card {
display: flex;
gap: 7vw;
padding-top: 10vw;
padding-bottom: 10vw;
}

.card img {
width: 40vw;
object-fit: contain;
}


.align-right {
justify-content: end;
}



.card-info {
display: flex;
flex-direction: column;
justify-content: center;
}

.align-right .card-info {
align-items: end;
text-align: right;
}

.card-title {
font-weight: 800;
color: var(--element-sky-color);
}

.card-description {
font-size: 2vw;
}

.card-right * {
margin-block-start: 0.3em;
margin-block-end: 0.3em;
}

.footer-main {
margin-top: 100px;
}

.footer-main {
background-color: var(--bg-sky-color);
display: flex;
justify-content: center;
align-items: center;
}

.footer-main img {
padding-top: 7%;
width: 50%
}

.footer-bottom-line {
background-color: var(--bg-navy-color);
color: var(--emelent-gray-color);
display: flex;
justify-content: space-around;
gap: 30px;
/* padding: 30px 200px 100px; */
padding-top: 30px;
padding-bottom: 100px;


}

.footer-bottom-line a {
text-decoration: none;
color: var(--white-color);
}

.footer-line-center {
display: flex;
gap: 2vw;
}
Loading