Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[최예원] Sprint10-2 #269

Merged

Conversation

ddol9
Copy link
Collaborator

@ddol9 ddol9 commented Jul 20, 2024

주요 변경사항

  • 지난 pr 리뷰 피드백 모두 반영하였습니다
  • 피그마 시안에 변경사항이 있어 적용하였습니다 (댓글 배경색 추가)

멘토에게

  • 미션11에서 요구되는 유저 기능은 아직 강의를 듣지 않아 미션10 리팩토링만 진행했습니다!
  • 주말 남는 시간동안 앞에서 진행한 미션들 마이그레이션 진행하겠습니당

@ddol9 ddol9 requested a review from jlstgt July 20, 2024 11:31
Copy link
Collaborator

@jlstgt jlstgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

거의 완벽하게 피드백 반영하셨네요! 😄 추가로 피드백 드릴 게 거의 없습니다.
Button 컴포넌트에 대해서 짤막하게 말씀드렸는데, 이 부분 한 번 참고해보시면 좋을 것 같습니다.
고생하셨습니다!

app/addboard/page.tsx Show resolved Hide resolved
components/Board/AllArticleCard.tsx Show resolved Hide resolved
styles/globals.css Show resolved Hide resolved
components/FileInput.tsx Show resolved Hide resolved
components/FileInput.tsx Show resolved Hide resolved
components/Button.tsx Show resolved Hide resolved
components/Board/BestArticleList.tsx Show resolved Hide resolved
@jlstgt jlstgt merged commit 4b5bb66 into codeit-bootcamp-frontend:Next-최예원 Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants