Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyh0521
approved these changes
Jul 1, 2024
Comment on lines
+9
to
+16
| <BrowserRouter> | ||
| <Routes> | ||
| <Route path="/" element={<HomePage />} /> | ||
| <Route path="items" element={<MarketPage />} /> | ||
| <Route path="login" element={<LoginPage />} /> | ||
| <Route path="additem" element={<AddItemPage />} /> | ||
| </Routes> | ||
| </BrowserRouter> |
There was a problem hiding this comment.
라우터 세팅 잘해주셨네요! 404 페이지도 작업해주시면 좋을 것 같습니다.
| const query = new URLSearchParams(params).toString(); | ||
| try { | ||
| const response = await fetch( | ||
| `https://panda-market-api.vercel.app/products?${query}` |
There was a problem hiding this comment.
baseURL 부분은 .env 파일로 관리하고 .gitignore에 추가해서 깃에 올라오지 않게 하는 것을 추천드려요!
src/components/header/Header.css
Outdated
| height: 70px; | ||
| padding: 0 200px; | ||
| gap: 20px; | ||
| border: 1px solid #dfdfdf; |
| import styled from 'styled-components'; | ||
| import Header from '../../header/Header'; | ||
|
|
||
| const Container = styled.div` |
There was a problem hiding this comment.
개인적으로 styled-component는 컴포넌트 하단에 작성해주는 편입니다. 컴포넌트의 디자인 요소가 많아질수록 컴포넌트가 하단에 나와서 확인하기가 불편하더라고요!
Comment on lines
+14
to
+16
| const bestItemList = itemList | ||
| .sort((a, b) => b.favoriteCount - a.favoriteCount) | ||
| .slice(0, 4); |
There was a problem hiding this comment.
api 요청보낼때, query에 favorite으로 요청보내면 좋아요 순으로 정렬되지 않나요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게