Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlgns2223
reviewed
Jun 30, 2024
| function AddItems() { | ||
| const [values, setValues] = useState(INITIAL_VALUES); | ||
| const [initialPreview, setInitialPreview] = useState(undefined); |
There was a problem hiding this comment.
setInitialPreview가 사용되지 않고 있어요. 그래서 이 라인을 지우고 ImageFileInput 컴포넌트에서 preview 상태의 초깃값을 undefined로 해주면 될 것 같습니다.
| function ImageFileInput({ | ||
| className = '', | ||
| name, | ||
| value, |
There was a problem hiding this comment.
value 보다는 어떤 상세한 변수명이 좋을 것 같습니다. 컴포넌트를 들여다 봤을때 이미지를 뜻하는거니까 productImage와 같이 좀 더 자세한 변수명을 사용해주세요.
| <> | ||
| <div className="card-input-image-file"> | ||
| <img | ||
| src={preview || ImgDeafault} |
There was a problem hiding this comment.
디폴트 이미지 사용해주신 점 아주 좋습니다 !
| <div className="wrapper-form-add-item"> | ||
| <form className="form-add-item" onSubmit={handleSubmit}> | ||
| <div className="wrapper-input-form-add-item"> | ||
| <label className="title-input-form-add-item">상품 이미지</label> |
There was a problem hiding this comment.
일반적인 제목을 나타낼 의도라면 p태그가 좀 더 적절하겠습니다 ㅎㅎ
| if (!values.tags.includes(tag)) { | ||
| handleChange( | ||
| 'tags', | ||
| values.tags.length > 0 ? [...values.tags, tag] : [tag] |
Comment on lines
+72
to
+76
| <Button | ||
| text="등록" | ||
| onClick={handleSubmit} | ||
| isDisabled={!isAllValid} | ||
| /> |
There was a problem hiding this comment.
submit 역할을 하는 버튼이므로 form 태그 안에 위치하는게 어떨까요?
|
스프린트 미션 수고하셨습니다 !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항[기본]
요구사항 [심화] [심화]
스크린샷
배포