Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlgns2223
reviewed
Aug 5, 2024
Comment on lines
+9
to
+11
| "@types/jest": "^27.5.2", | ||
| "@types/react": "^18.3.3", | ||
| "@types/react-dom": "^18.3.0", |
There was a problem hiding this comment.
@types 관련 의존성들은 devDependancy에 설치를 해주세요.
devDependency에 설치된 의존성 파일들은 최종 빌드시에 포함되지 않아 번들 사이즈가 줄어듭니다.
Comment on lines
+3
to
+8
| interface FormData { | ||
| name: string; | ||
| info: string; | ||
| price: string; | ||
| tag: string; | ||
| } |
Comment on lines
+22
to
+30
| interface Product { | ||
| id: number; | ||
| name: string; | ||
| info: string; | ||
| price: number; | ||
| tag: string; | ||
| images: string; | ||
| favoriteCount: number; | ||
| } |
There was a problem hiding this comment.
API 문서에 나와 있는 Product의 데이터 구조를 그대로 작성해주시는것이 좋을 것 같습니다.
아래의 구조를 따라서 Product의 데이터 타입을 완성해주세요.
특히 tag는 string 타입이 아니라 string의 배열타입이네요 ~
{
"createdAt": "2024-08-05T08:25:27.138Z",
"favoriteCount": 0,
"ownerId": 1,
"images": [
"https://example.com/..."
],
"tags": [
"전자제품"
],
"price": 0,
"description": "string",
"name": "상품 이름",
"id": 1
}
Comment on lines
+19
to
+27
| interface Product { | ||
| id: number; | ||
| name: string; | ||
| info: string; | ||
| price: number; | ||
| tag: string; | ||
| images: string; | ||
| favoriteCount: number; | ||
| } |
There was a problem hiding this comment.
AllProduct에서 Product 타입을 정의를 했으니까 그 타입을 재사용해야합니다. AllProduct에서 정의한 타입을 가져와서 재사용해주세요.
There was a problem hiding this comment.
Writer, Product, Comment 꼼꼼한 타입지정 잘 하셨네요. UI를 구성하기 위한 객체는 왠만하면 다 타입지정을 해주시는게 좋습니다. 다만 Product타입은 다른 페이지에서 많이 사용되고 있으니 재사용을 해주세요.
Comment on lines
+33
to
+40
| const [products, setProducts] = useState<Product[]>([]); | ||
| const [page, setPage] = useState<number>(1); | ||
| const [pageSize, setPageSize] = useState<number>(10); | ||
| const [order, setOrder] = useState<string>(RECENT); | ||
| const [dropArrow, setDropArrow] = useState<string>(""); | ||
| const [dropDisplay, setDropDisplay] = useState<string>("none"); | ||
| const [orderTxt, setOrderTxt] = useState<string>("최신순"); | ||
| const [pagesNum, setPagesNum] = useState<number[]>([1, 2]); |
There was a problem hiding this comment.
useState에 상태들의 꼼꼼한 타입 명시 좋습니다 !!
|
스프린트 미션 수고하셨습니다. 전반적으로 타입을 잘 만드셨고, 타입 재사용을 좀 더 적극적으로 하시면 될 것 같습니다 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
주요 변경사항
멘토에게