Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 14, 2024 01:12
boolean이 아닌 number state를 리턴하도록 수정
jyh0521
approved these changes
Aug 19, 2024
Comment on lines
+1
to
+5
| export default interface ArticlePost { | ||
| image: string; | ||
| content: string; | ||
| title: string; | ||
| } |
There was a problem hiding this comment.
post의 body 타입은 보통 PostArticleBody 같은 이름도 추천드려요
Comment on lines
+6
to
+10
| writer: { | ||
| id: number; | ||
| nickname: string; | ||
| image: string; | ||
| } |
| @@ -0,0 +1,11 @@ | |||
| export default interface CommentType { | |||
| <div className={styles.articleWriter}> | ||
| <div className={styles.profileImageContainer}> | ||
| <Image fill src="/images/ic_profile.png" alt="프로필" /> | ||
| <Link href={`boards/${article.id}`} style={{ textDecoration: "none"}}> |
| @@ -64,4 +64,24 @@ | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| .loginButton { | |||
There was a problem hiding this comment.
css 옵션 관련있는것끼리 깔끔하게 잘 정리해주셨네요!
| const [isDropdownOpen, setIsDropdownOpen] = useState(false); | ||
| const [isDropdownClicked, setIsDropdownClicked] = useState(false); | ||
| const [isDocumentClicked, setIsDocumentClicked] = useState(false); | ||
| const [dropdownState, setDropdownState] = useState(0); |
There was a problem hiding this comment.
이 상태를 숫자로 관리해주셨는데, 혹시 어떤 의미일까요?
| nextCursor: number | null; | ||
| } | ||
|
|
||
| export const getServerSideProps: GetServerSideProps = async (context) => { |
There was a problem hiding this comment.
getServerSideProps 활용 잘해주셨네요!
Comment on lines
+24
to
+31
| let article: ArticleType; | ||
| try { | ||
| article = await getArticle(id); | ||
| } catch { | ||
| return { | ||
| notFound: true | ||
| } | ||
| } |
There was a problem hiding this comment.
이 로직은 어차피 해당 id에 해당하는 데이터를 불러오지 않는다면 다른 값들이 null일 것이기 때문에 그것들로 예외처리를 해보시는 것도 괜찮을 것 같습니다.
|
질문은 멘토링 시간에 같이 보면 좋을 것 같습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게