Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1
to
+3
| import ArticleSection from "@/components/Boards/ArticleSection"; | ||
| import BestArticleSection from "@/components/Boards/BestArticleSection"; | ||
| import Header from "@/components/Header"; |
There was a problem hiding this comment.
현재 디렉토리 가져올 때 @/components 되어있는데, tsconfig 값에 paths 수정하는 방향으로 아래처럼 바꿔보면 가독성이 더 좋을 것 같습니다 😄
import ArticleSection from "@components/Boards/ArticleSection";
import BestArticleSection from "@components/Boards/BestArticleSection";
import Header from "@components/Header";
arthurkimdev
approved these changes
Aug 21, 2024
Comment on lines
+10
to
+12
| const handleChange = (e: ChangeEvent<HTMLInputElement>) => { | ||
| setValue(e.target.value); | ||
| }; |
There was a problem hiding this comment.
아래처럼 이벤트 핸들러 함수들은 useCallback 사용해서 메모이제이션하는 방법도 있어요. 이런 경우, 불필요한 리랜더링을 방지해줄 수 있습니다.
Suggested change
| const handleChange = (e: ChangeEvent<HTMLInputElement>) => { | |
| setValue(e.target.value); | |
| }; | |
| const handleChange = useCallback((e: React.ChangeEvent<HTMLInputElement>) => { | |
| setValue(e.target.value); | |
| }, []); |
Comment on lines
+5
to
+24
| // const [articles, setArticles] = useState(); | ||
|
|
||
| // // const viewportWidth = useViewport(); | ||
|
|
||
| // useEffect(() => { | ||
| // // if (viewportWidth === 0) return; | ||
|
|
||
| // const fetchBestArticles = async (size: number) => { | ||
| // try { | ||
| // const response = await fetch( | ||
| // `https://panda-market-api.vercel.app/articles?orderBy=like&pageSize=${size}` | ||
| // ); | ||
| // const data: ArticleListResponse = await response.json(); | ||
| // setArticles(data.list); | ||
| // } catch (error) { | ||
| // console.error("Failed to fetch best articles:", error); | ||
| // } | ||
| // fetchBestArticles(newPageSize); | ||
| // }; | ||
| // }, []); |
There was a problem hiding this comment.
불필요한 주석은 제거해주시는게 좋아요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게