Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlgns2223
reviewed
Sep 30, 2024
| ); | ||
| } | ||
|
|
||
| const queryClient = new QueryClient(); |
There was a problem hiding this comment.
queryClient를 외부에 선언해도 되지만 좀 더 정확하게는 state로 선언하시더라구요. 매 request마다 클라이언트 사이드에서 쿼리클라이언트가 확실히 초기화되어있기를 보장하기 위해서 입니다.
아래의 링크를 확인해보세요.
| @@ -20,20 +16,28 @@ function Navbar() { | |||
| const isActive = | |||
| location.pathname === "/additem" || location.pathname === "/items"; | |||
|
|
|||
| const accessToken = localStorage.getItem("accessToken"); | |||
There was a problem hiding this comment.
useEffect 내부에서 local storage에 접근하는게 더 안전한 접근법 일 것 같습니다.
코드를 읽는 속도와 로컬 스토리지에서 가져오는 속도차이로 undefined가 있을수도 있지 않을까 생각이 들어요.
| try { | ||
| const query = new URLSearchParams(params as any).toString(); | ||
|
|
||
| const response = await fetch(`${BASE_URL}/products?${query}`); |
There was a problem hiding this comment.
acess token을 사용하시려면 axios가 더 편할수도 있는데 fetch를 사용하신 이유가 있을까요?
Comment on lines
+21
to
+26
| useEffect(() => { | ||
| const accessToken = localStorage.getItem("accessToken"); | ||
| if (accessToken) { | ||
| navigate("/"); | ||
| } | ||
| }, [navigate]); |
There was a problem hiding this comment.
acess token이 없을 경우 다른 페이지로 이동을 해야하는 경우. 이를 protected page라고 합니다.
HOC 패턴으로 해당 로직을 쉽게 풀 수 있습니다.
protected router + HOC pattern으로 해당 로직을 패턴화 시켜보세요 !
https://patterns-dev-kr.github.io/design-patterns/hoc-pattern/
잘 이해가 안가면 DM을 주시면 멘토링때 같이 살펴보시면 좋을 것 같습니다.
Comment on lines
+45
to
+49
| className={classNames("auth-input", { | ||
| required: true, | ||
| error: errors.email, | ||
| valid: isSubmitted, | ||
| })} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
회원가입
로그인
메인
로컬 스토리지에 accessToken이 있는 경우 상단바 ‘로그인’ 버튼이 판다 이미지로 바뀝니다.
스프린트 미션 12
api 요청에 TanStack React Query를 활용해 주세요.
중고마켓
상품 상세
상품 등록
심화
주요 변경사항
멘토에게