Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Fix wildcard issue #118

Merged
merged 1 commit into from
Mar 2, 2024
Merged

bugfix: Fix wildcard issue #118

merged 1 commit into from
Mar 2, 2024

Conversation

codekeyz
Copy link
Owner

@codekeyz codekeyz commented Mar 2, 2024

Description

Use last wildcard found along route when no matched route.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codekeyz codekeyz added the bug Something isn't working label Mar 2, 2024
@codekeyz codekeyz self-assigned this Mar 2, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 76.19048% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 74.44%. Comparing base (d33c5c1) to head (41c11d7).

Files Patch % Lines
packages/spanner/lib/src/tree/tree.dart 75.00% 4 Missing ⚠️
packages/spanner/lib/src/tree/node.dart 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   75.06%   74.44%   -0.63%     
==========================================
  Files          34       34              
  Lines        1115     1119       +4     
==========================================
- Hits          837      833       -4     
- Misses        278      286       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codekeyz codekeyz merged commit 8901578 into main Mar 2, 2024
2 checks passed
@codekeyz codekeyz deleted the fix/fix-wildcard-bug branch March 2, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants