Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade & fix break change in jsonschema #130

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

parberge
Copy link
Member

Followed the information from https://github.com/Stranger6667/jsonschema/blob/HEAD/MIGRATION.md#upgrading-from-025x-to-0260

I don't know if we have any tests that make sure we get validation error? If not maybe something that can be added. Not sure how though 😄

dependabot bot and others added 2 commits December 16, 2024 12:19
Bumps [jsonschema](https://github.com/Stranger6667/jsonschema) from 0.21.0 to 0.26.2.
- [Release notes](https://github.com/Stranger6667/jsonschema/releases)
- [Changelog](https://github.com/Stranger6667/jsonschema/blob/master/CHANGELOG.md)
- [Commits](Stranger6667/jsonschema@rust-v0.21.0...rust-v0.26.2)

---
updated-dependencies:
- dependency-name: jsonschema
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@parberge parberge changed the title Fix break change in jsonschema Upgrade & fix break change in jsonschema Dec 17, 2024
@parberge
Copy link
Member Author

Relates to #129

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 368 lines in your changes missing coverage. Please review.

Project coverage is 83.87%. Comparing base (95e628b) to head (9aa6852).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/tests/schema_validation/v2_0_1.rs 33.33% 256 Missing ⚠️
src/tests/schema_validation/v1_6.rs 33.33% 112 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
+ Coverage   81.68%   83.87%   +2.18%     
==========================================
  Files          51       51              
  Lines        4347     3795     -552     
==========================================
- Hits         3551     3183     -368     
+ Misses        796      612     -184     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@parberge
Copy link
Member Author

Codecov Report

Attention: Patch coverage is 33.33333% with 368 lines in your changes missing coverage. Please review.

Project coverage is 83.87%. Comparing base (71c5023) to head (2240d59).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/tests/schema_validation/v2_0_1.rs 33.33% 256 Missing ⚠️
src/tests/schema_validation/v1_6.rs 33.33% 112 Missing ⚠️
Additional details and impacted files
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

@tommymalmqvist Not sure why this happens. Do you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants