-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade & fix break change in jsonschema #130
base: main
Are you sure you want to change the base?
Conversation
Bumps [jsonschema](https://github.com/Stranger6667/jsonschema) from 0.21.0 to 0.26.2. - [Release notes](https://github.com/Stranger6667/jsonschema/releases) - [Changelog](https://github.com/Stranger6667/jsonschema/blob/master/CHANGELOG.md) - [Commits](Stranger6667/jsonschema@rust-v0.21.0...rust-v0.26.2) --- updated-dependencies: - dependency-name: jsonschema dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Relates to #129 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
+ Coverage 81.68% 83.87% +2.18%
==========================================
Files 51 51
Lines 4347 3795 -552
==========================================
- Hits 3551 3183 -368
+ Misses 796 612 -184 ☔ View full report in Codecov by Sentry. |
@tommymalmqvist Not sure why this happens. Do you? |
That I missed when rewriting
Followed the information from https://github.com/Stranger6667/jsonschema/blob/HEAD/MIGRATION.md#upgrading-from-025x-to-0260
I don't know if we have any tests that make sure we get validation error? If not maybe something that can be added. Not sure how though 😄