Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Integration Test #150

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add Integration Test #150

wants to merge 15 commits into from

Conversation

jeeyo
Copy link
Collaborator

@jeeyo jeeyo commented Jul 26, 2023

  • separate App class from entrypoint
  • Config now doesn't parse process.argv on startup
  • GitLabMRService accepts only arguments that it needs, not entire configs object
  • Add unit tests for App class
  • Add integration tests using smocker

@jeeyo jeeyo mentioned this pull request Jul 26, 2023
Closed
@jeeyo jeeyo marked this pull request as ready for review July 31, 2023 03:36
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
12.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jeeyo