chore: upgrade Proto code to Swift 6

[spikecurtis]

Upgrades Proto to Swift 6, mostly by telling the compiler explicitly that things are sendable, but in some cases by scoping down our closures so they only capture sendable objects.

[spikecurtis]

• chore: upgrade Proto code to Swift 6 #14 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ethanndickson]

Just thinking about it after the fact, is there a reason we wouldn't want to make Speaker & Handshaker an actor?

[spikecurtis]

Just thinking about it after the fact, is there a reason we wouldn't want to make Speaker & Handshaker an actor?

The reason I didn't make Speaker and actor is that as far as I can tell, actors don't have inheritance. An alternative design might be to make the Speaker an actor, and then have the Tunnel and/or Manager compose a Speaker internally. However, we'd have to rethink the way the outer object gets notified about messages and RPCs --- overriding handlers won't work.

For the Handshaker, I was having trouble getting it to work because of the way we use DispatchIO callbacks to write to the data: data has to be mutable and DispatchIO callbacks aren't async. I couldn't figure out how to make an actor work for that.

[spikecurtis]

Merge activity

• Dec 19, 4:46 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Dec 19, 4:46 AM EST: A user merged this pull request with Graphite.