New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use Lchown to prevent erroring on broken symlinks #434

Merged

mafredri merged 1 commit into coder:main from strike:main

Dec 12, 2024

Contributor

strike commented Dec 10, 2024

It's better to use Lchown instead Chown because:

there are dummy/broken symlinks may use in repository. For example, we use dummy/broken symlinks for tests.
some software create dummy symlinks in users home. For example, nix with options --no-channel-add create broken symlinks:

root ➜ / $ ls -l /home/vscode/.nix-defexpr/channels_root
lrwxrwxrwx 1 root root 44 Dec  3 15:34 /home/vscode/.nix-defexpr/channels_root -> /nix/var/nix/profiles/per-user/root/channels
root ➜ / $  ls -l  /nix/var/nix/profiles/per-user/root/channels
ls: cannot access '/nix/var/nix/profiles/per-user/root/channels': No such file or directory

Without this PR envbuilder fails with error:

chown "/home/vscode": chown /home/vscode/.nix-defexpr/channels_root: no such file or directory


          fix: Do not fail chown on dummy symlinks

35c550a

matifali requested a review from mafredri

December 12, 2024 07:38

mafredri approved these changes

View reviewed changes

Member

mafredri left a comment

Thanks for fixing this!

mafredri changed the title ~~fix: Do not fail chown on dummy symlinks~~ fix: use Lchown to prevent erroring on broken symlinks

mafredri merged commit 440ac5c into coder:main

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet