KUBESAW-147: Space controller updates tier-hash label based on the NSTemplateTier.Status.Revisions field #1135
Conversation
…TemplateTier.Status.Revisions field Signed-off-by: Feny Mehta <[email protected]>
fbm3307
requested review from
MatousJobanek,
xcoulon,
alexeykazakov,
rajivnathan,
ranakan19,
mfrancisc,
rsoaresd and
metlos
as code owners
Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]> Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
…evisions Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
|
/test e2e |
|
/test-e2e |
|
/test e2e |
| @@ -49,8 +50,7 @@ func (r *Reconciler) SetupWithManager(mgr ctrl.Manager, memberClusters map[strin | |||
| // watch Spaces in the host cluster | |||
| For(&toolchainv1alpha1.Space{}, builder.WithPredicates(predicate.Or(predicate.GenerationChangedPredicate{}, predicate.AnnotationChangedPredicate{}))). | |||
| Watches(&toolchainv1alpha1.NSTemplateTier{}, | |||
| handler.EnqueueRequestsFromMapFunc(MapNSTemplateTierToSpaces(r.Namespace, r.Client)), | |||
| builder.WithPredicates(predicate.GenerationChangedPredicate{})). | |||
There was a problem hiding this comment.
as soon as we introduce the conditions, we should add a predicate to watch only ready NSTemplateSets
There was a problem hiding this comment.
if predicates are there, it only reconciles when there is change in spec and does not reconcile for the changes in status.revisions ,and hence the hash of space is not being updated, thats the reason i removed the predicates, ( it failed in e2e test for different hash of space label due to old hash)
There was a problem hiding this comment.
or you mean some other predicate ?
There was a problem hiding this comment.
yes, I had another predicate in mind. But my comment was for later improvement, not for now. We still don't set/manage conditions in NSTemplateTiers.
cc @mfrancisc
There was a problem hiding this comment.
@MatousJobanek what type of predicate did you had in mind for the ready condition ?
Signed-off-by: Feny Mehta <[email protected]>
There was a problem hiding this comment.
could you please take a look at the CodeCov comments in pkg/templates/nstemplatetiers/nstemplatetier_refs.go file?
Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
it didnt have unit tests. |
Signed-off-by: Feny Mehta <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fbm3307, MatousJobanek, mfrancisc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Feny Mehta <[email protected]>
Signed-off-by: Feny Mehta <[email protected]>
|
Codecov ReportAttention: Patch coverage is
❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## master #1135 +/- ##
==========================================
+ Coverage 79.47% 79.66% +0.19%
==========================================
Files 81 82 +1
Lines 8130 8154 +24
==========================================
+ Hits 6461 6496 +35
+ Misses 1481 1467 -14
- Partials 188 191 +3
|
This PR is to update the space controller to compute the tier-hash label value using the NSTemplateTier.Status.Revisions field so that it can match outdated spaces using the new revisions mechanism.
Jira-Link - KUBESAW-147
Related PR
Paired PR