Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Public-Viewer support #443

Merged
merged 87 commits into from
Sep 26, 2024
Merged

Conversation

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 92.70833% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.89%. Comparing base (c828088) to head (0ffff03).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/proxy/proxy.go 92.70% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
+ Coverage   81.14%   81.89%   +0.75%     
==========================================
  Files          42       42              
  Lines        2630     2707      +77     
==========================================
+ Hits         2134     2217      +83     
+ Misses        408      404       -4     
+ Partials       88       86       -2     
Flag Coverage Δ
unittests 81.89% <92.70%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@filariow
Copy link
Contributor Author

/retest

filariow added 3 commits July 12, 2024 16:42
Signed-off-by: Francesco Ilario <[email protected]>
This commit adds the notion of Public-Viewer to the Proxy as described
in [JIRA ASC-532](https://issues.redhat.com/browse/ASC-532).

Signed-off-by: Francesco Ilario <[email protected]>
@filariow filariow force-pushed the pv-532 branch 2 times, most recently from 28896b4 to e360c1f Compare July 12, 2024 15:22
filariow added 3 commits July 12, 2024 18:21
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Copy link
Contributor

@alexeykazakov alexeykazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a big PR. I only half way through it :)

pkg/context/keys.go Outdated Show resolved Hide resolved
pkg/proxy/handlers/spacelister_get.go Outdated Show resolved Hide resolved
pkg/proxy/handlers/spacelister_get.go Outdated Show resolved Hide resolved
pkg/proxy/handlers/spacelister_get.go Outdated Show resolved Hide resolved
pkg/proxy/handlers/spacelister_get_test.go Outdated Show resolved Hide resolved
pkg/proxy/handlers/spacelister_list.go Outdated Show resolved Hide resolved
pkg/proxy/handlers/spacelister_list.go Outdated Show resolved Hide resolved
pkg/proxy/handlers/spacelister_list_test.go Outdated Show resolved Hide resolved
pkg/proxy/handlers/spacelister_list_test.go Outdated Show resolved Hide resolved
pkg/proxy/handlers/spacelister_list_test.go Outdated Show resolved Hide resolved
filariow and others added 7 commits July 15, 2024 10:33
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
@filariow filariow marked this pull request as draft July 15, 2024 09:42
@filariow filariow requested a review from mfrancisc September 23, 2024 11:35
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
Signed-off-by: Francesco Ilario <[email protected]>
@filariow
Copy link
Contributor Author

Looks good! Thank you for addressing the comments! However there is a few lines not covered by the tests. Check out the codecov report. Could you please take a look and see if you can add the missing tests if it's not too tricky?

I've worked on some of them. I could not find an easy fix for the others. AFAIUI, they are happening because the same check was already performed by another function in the chain, like retrieving two times the UserSignup or Space info. I tried refactoring but it was requiring too many changes. Maybe we can refactor later in another PR. WDYT?

@alexeykazakov
Copy link
Contributor

Maybe we can refactor later in another PR. WDYT?

Yes, sure. As I said let's do it if it's not too tricky. Otherwise it's OK to leave it as is.

Signed-off-by: Francesco Ilario <[email protected]>
Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job 🚀 🏅

Thanks for the additional improvements/tests and for addressing my comments.

Signed-off-by: Francesco Ilario <[email protected]>
@filariow
Copy link
Contributor Author

/retest

Signed-off-by: Francesco Ilario <[email protected]>
Copy link

sonarcloud bot commented Sep 26, 2024

Copy link

openshift-ci bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, filariow, mfrancisc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alexeykazakov,mfrancisc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@filariow filariow merged commit 283ead3 into codeready-toolchain:master Sep 26, 2024
10 of 11 checks passed
@filariow filariow deleted the pv-532 branch September 26, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants